From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga09.intel.com ([134.134.136.24]:14798 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755310Ab2B2QMr (ORCPT ); Wed, 29 Feb 2012 11:12:47 -0500 Subject: Re: [PATCH -iwlwifi] iwlwifi: make tx_cmd_pool kmem cache global From: "Guy, Wey-Yi" To: Johannes Berg Cc: Stanislaw Gruszka , Intel Linux Wireless , linux-wireless@vger.kernel.org In-Reply-To: <1330506013.4714.3.camel@jlt3.sipsolutions.net> References: <1330350725-5815-1-git-send-email-sgruszka@redhat.com> (sfid-20120227_145218_640279_81755758) <1330506013.4714.3.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Date: Wed, 29 Feb 2012 07:00:22 -0800 Message-ID: <1330527622.12612.24.camel@wwguy-huron> (sfid-20120229_171256_495180_85562CDB) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2012-02-29 at 10:00 +0100, Johannes Berg wrote: > On Mon, 2012-02-27 at 14:52 +0100, Stanislaw Gruszka wrote: > > Otherwise we are not able to run more than one device per driver: > > > > [ 24.743045] kmem_cache_create: duplicate cache iwl_dev_cmd > > [ 24.743051] Pid: 3165, comm: NetworkManager Not tainted 3.3.0-rc2-wl+ #5 > > [ 24.743054] Call Trace: > > [ 24.743066] [] kmem_cache_create+0x655/0x700 > > [ 24.743073] [] ? destroy_timer_on_stack+0x15/0x20 > > [ 24.743079] [] ? schedule_timeout+0x1dd/0x330 > > [ 24.743083] [] ? lock_timer_base+0x70/0x70 > > [ 24.743101] [] iwl_alive_notify+0x1cb/0x1f0 [iwlwifi] > > [ 24.743111] [] iwl_load_ucode_wait_alive+0x1b2/0x220 [iwlwifi] > > [ 24.743118] [] ? trace_hardirqs_on+0xd/0x10 > > [ 24.743127] [] ? iwlagn_mac_setup_register+0x2e0/0x2e0 [iwlwifi] > > [ 24.743133] [] ? _raw_spin_unlock_bh+0x34/0x40 > > [ 24.743142] [] iwl_run_init_ucode+0x73/0x100 [iwlwifi] > > [ 24.743152] [] __iwl_up+0x81/0x220 [iwlwifi] > > [ 24.743161] [] iwlagn_mac_start+0x80/0x190 [iwlwifi] > > [ 24.743188] [] ieee80211_do_open+0x293/0x770 [mac80211] > > I'll pick this up. > Thanks, I will merge it once it is there. Wey >