From: Johannes Berg <johannes@sipsolutions.net>
To: Bala Shanmugam <bkamatch@qca.qualcomm.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] cfg80211: Add background scan period attribute.
Date: Thu, 01 Mar 2012 15:23:49 +0100 [thread overview]
Message-ID: <1330611829.3623.6.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1330583965-8415-1-git-send-email-bkamatch@qca.qualcomm.com> (sfid-20120301_073937_156683_BFB54260)
On Thu, 2012-03-01 at 12:09 +0530, Bala Shanmugam wrote:
> Receive background scan period as part of connect
> command and pass the same to driver.
>
> Signed-off-by: Bala Shanmugam <bkamatch@qca.qualcomm.com>
> ---
> include/linux/nl80211.h | 9 +++++++++
> include/net/cfg80211.h | 3 +++
> net/wireless/nl80211.c | 7 +++++++
> net/wireless/wext-sme.c | 3 +++
> 4 files changed, 22 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/nl80211.h b/include/linux/nl80211.h
> index be35a68..e81d327 100644
> --- a/include/linux/nl80211.h
> +++ b/include/linux/nl80211.h
> @@ -369,6 +369,10 @@
> * %NL80211_ATTR_WIPHY_FREQ, %NL80211_ATTR_CONTROL_PORT,
> * %NL80211_ATTR_CONTROL_PORT_ETHERTYPE and
> * %NL80211_ATTR_CONTROL_PORT_NO_ENCRYPT.
> + * Background scan period can optionally be
> + * specified in %NL80211_ATTR_BG_SCAN_PERIOD,
> + * if not specified default background scan configuration
> + * in driver is used and if period value is 0, bg scan will be disabled.
Maybe this should also indicate that the value is ignored unless the
device advertises roaming support with NL80211_ATTR_ROAM_SUPPORT?
I'm not sure I like the whole default value thing since it's kinda
magic, but I guess I can live with it.
johannes
next prev parent reply other threads:[~2012-03-01 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 6:39 [PATCH v2] cfg80211: Add background scan period attribute Bala Shanmugam
2012-03-01 14:23 ` Johannes Berg [this message]
2012-03-07 11:55 ` bkamatch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330611829.3623.6.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=bkamatch@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).