From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless@vger.kernel.org, devel@lists.open80211s.org,
linville@tuxdriver.com
Subject: Re: [PATCH 3/3] mac80211: fix mesh airtime link metric estimating
Date: Sat, 03 Mar 2012 00:18:36 +0100 [thread overview]
Message-ID: <1330730316.3865.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1330729524-1010-3-git-send-email-thomas@cozybit.com> (sfid-20120303_000604_467410_A1483369)
On Fri, 2012-03-02 at 15:05 -0800, Thomas Pedersen wrote:
> Airtime link metric estimation was broken in HT mesh, use
> cfg80211_calculate_bitrate to get the right rate value.
> - if (sta->last_tx_rate.flags & IEEE80211_TX_RC_MCS)
> + sta_set_sinfo(sta, &sinfo);
> + rate = cfg80211_calculate_bitrate(&sinfo.txrate);
> + if (WARN_ON(!rate))
> return MAX_METRIC;
Patch 1 should be rolled into this, but I don't like it -- you fill a
lot of info you don't need, I think the rate should be factored out of
sta_set_sinfo then
johannes
next prev parent reply other threads:[~2012-03-02 23:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 23:05 [PATCH 1/3] mac80211: expose sta_set_sinfo() Thomas Pedersen
2012-03-02 23:05 ` [PATCH 2/3] cfg80211: expose cfg80211_calculate_bitrate() Thomas Pedersen
2012-03-02 23:05 ` [PATCH 3/3] mac80211: fix mesh airtime link metric estimating Thomas Pedersen
2012-03-02 23:18 ` Johannes Berg [this message]
2012-03-02 23:29 ` Thomas Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330730316.3865.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).