linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	651199@bugs.debian.org, Ben Hutchings <ben@decadent.org.uk>,
	Wey-Yi Guy <wey-yi.w.guy@intel.com>,
	Intel Linux Wireless <ilw@linux.intel.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andreas Gustafsson <olangu@impressions.se>,
	Marco d'Itri <md@Linux.IT>,
	Gabriel Kerneis <kerneis@pps.jussieu.fr>,
	Shawn Thompson <shawn@projektenterprises.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: iwlwifi WPA-TKIP crypto failure after group rekeying
Date: Mon, 05 Mar 2012 07:52:23 +0100	[thread overview]
Message-ID: <1330930343.3545.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20120305045334.GF30344@burratino> (sfid-20120305_055451_570064_79E67075)

Hi,

> >> To summarise, a WPA-TKIP managed connection stops passing traffic and
> >> the kernel log shows the message "WPA: Group rekeying".  This apparently
> >> doesn't happen if the connection is in heavy use at the time or with
> >> module parameter swcrypto=1.  WPA2 is not affected either.
> >
> > I think this is due to my patch "iwlagn: rewrite HW crypto" which
> > accidentally broke key *removal* (of all things), which causes issues
> > when the first GTK is removed on the second rekeying.
> >
> > This patch
> > [...]h=5dcbf480473f6c3f06ad2426b7517038a2a18911
> >
> > should fix it. Wey has sent it to John
> [...]
> > it's also marked for stable.
> 
> Shawn Thompson (cc-ed) tested the patch against 3.2.9 and 3.3-rc6 and
> found it to work[1].  What can interested people do to help usher this
> into mainline?

Great, thanks for testing. The patch is already on the way into mainline
with a Cc:stable tag, so I don't think there's anything to do at this
point.

johannes


      reply	other threads:[~2012-03-05  6:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-27  5:33 iwlwifi WPA-TKIP crypto failure after group rekeying Ben Hutchings
2012-02-27  9:02 ` Johannes Berg
2012-02-27 13:59   ` Guy, Wey-Yi
2012-02-28  2:02   ` Jonathan Nieder
2012-03-05  4:53   ` Jonathan Nieder
2012-03-05  6:52     ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330930343.3545.1.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=651199@bugs.debian.org \
    --cc=ben@decadent.org.uk \
    --cc=ilw@linux.intel.com \
    --cc=jrnieder@gmail.com \
    --cc=kerneis@pps.jussieu.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=md@Linux.IT \
    --cc=netdev@vger.kernel.org \
    --cc=olangu@impressions.se \
    --cc=shawn@projektenterprises.com \
    --cc=torvalds@linux-foundation.org \
    --cc=wey-yi.w.guy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).