From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211/mac80211: report signal strength for mgmt frames
Date: Mon, 05 Mar 2012 22:00:39 +0100 [thread overview]
Message-ID: <1330981239.3545.12.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20120305204251.GH18128@tuxdriver.com>
On Mon, 2012-03-05 at 15:42 -0500, John W. Linville wrote:
> On Fri, Mar 02, 2012 at 01:40:35PM +0100, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > Add the signal strength (in dBm only for now) to
> > frames that are received via nl80211's various
> > frame APIs.
> >
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> > ---
> > include/linux/nl80211.h | 6 ++++++
> > include/net/cfg80211.h | 8 +++++---
> > net/mac80211/rx.c | 13 +++++++++++--
> > net/wireless/mlme.c | 7 ++++---
> > net/wireless/nl80211.c | 9 +++++++--
> > net/wireless/nl80211.h | 3 ++-
> > 6 files changed, 35 insertions(+), 11 deletions(-)
>
> CC drivers/net/wireless/ath/ath6kl/wmi.o
> drivers/net/wireless/ath/ath6kl/wmi.c: In function ‘ath6kl_wmi_rx_probe_req_event_rx’:
> drivers/net/wireless/ath/ath6kl/wmi.c:559:3: warning: passing argument 3 of ‘cfg80211_rx_mgmt’ makes integer from pointer without a cast
> include/net/cfg80211.h:3205:6: note: expected ‘int’ but argument is of type ‘u8 *’
> drivers/net/wireless/ath/ath6kl/wmi.c:559:3: warning: passing argument 4 of ‘cfg80211_rx_mgmt’ makes pointer from integer without a cast
> include/net/cfg80211.h:3205:6: note: expected ‘const u8 *’ but argument is of type ‘u16’
> drivers/net/wireless/ath/ath6kl/wmi.c:559:3: error: too few arguments to function ‘cfg80211_rx_mgmt’
> include/net/cfg80211.h:3205:6: note: declared here
> drivers/net/wireless/ath/ath6kl/wmi.c: In function ‘ath6kl_wmi_rx_action_event_rx’:
> drivers/net/wireless/ath/ath6kl/wmi.c:598:2: warning: passing argument 3 of ‘cfg80211_rx_mgmt’ makes integer from pointer without a cast
> include/net/cfg80211.h:3205:6: note: expected ‘int’ but argument is of type ‘u8 *’
> drivers/net/wireless/ath/ath6kl/wmi.c:598:2: warning: passing argument 4 of ‘cfg80211_rx_mgmt’ makes pointer from integer without a cast
> include/net/cfg80211.h:3205:6: note: expected ‘const u8 *’ but argument is of type ‘u16’
> drivers/net/wireless/ath/ath6kl/wmi.c:598:2: error: too few arguments to function ‘cfg80211_rx_mgmt’
> include/net/cfg80211.h:3205:6: note: declared here
> make[3]: *** [drivers/net/wireless/ath/ath6kl/wmi.o] Error 1
Oh crap, I forgot about ath6kl, sorry!
johannes
next prev parent reply other threads:[~2012-03-05 21:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 12:40 [PATCH] cfg80211/mac80211: report signal strength for mgmt frames Johannes Berg
2012-03-05 20:42 ` John W. Linville
2012-03-05 21:00 ` Johannes Berg [this message]
2012-03-05 21:18 ` [PATCH v2] " Johannes Berg
2012-03-06 13:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330981239.3545.12.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).