From: Johannes Berg <johannes@sipsolutions.net>
To: John Linville <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, Sujith <m.sujith@gmail.com>,
Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Subject: Re: [PATCH 4/6] mac80211: remove spurious BSSID change flag
Date: Thu, 08 Mar 2012 17:13:37 +0100 [thread overview]
Message-ID: <1331223217.1598.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20120308140227.133587480@sipsolutions.net> (sfid-20120308_150328_058540_9FB5A49A)
> The BSSID has been set a lot earlier already and
> didn't change again in ieee80211_set_associated().
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> net/mac80211/mlme.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> --- a/net/mac80211/mlme.c 2012-03-08 13:55:16.000000000 +0100
> +++ b/net/mac80211/mlme.c 2012-03-08 13:55:22.000000000 +0100
> @@ -1351,9 +1351,6 @@ static void ieee80211_set_associated(str
> */
> bss_info_changed |= BSS_CHANGED_BASIC_RATES;
>
> - /* And the BSSID changed - we're associated now */
> - bss_info_changed |= BSS_CHANGED_BSSID;
Sujith tells me that this will break ath9k -- Rajkumar, can you take a
look at this? Before your commit 99e4d43ad5ff5778f92ee3bc40a29a ath9k
did listen to BSS_CHANGED_ASSOC -- it seems like it should again?
johannes
next prev parent reply other threads:[~2012-03-08 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 14:02 [PATCH 0/6] mac80211 MLME cleanups & a fix Johannes Berg
2012-03-08 14:02 ` [PATCH 1/6] mac80211: move misplaced comment Johannes Berg
2012-03-08 14:02 ` [PATCH 2/6] mac80211: simplify HT checks Johannes Berg
2012-03-08 14:02 ` [PATCH 3/6] mac80211: simplify wmm check during association Johannes Berg
2012-03-08 14:02 ` [PATCH 4/6] mac80211: remove spurious BSSID change flag Johannes Berg
2012-03-08 16:13 ` Johannes Berg [this message]
2012-03-09 23:40 ` Manoharan, Rajkumar
2012-03-08 14:02 ` [PATCH 5/6] mac80211: refactor common auth/assoc setup code Johannes Berg
2012-03-08 14:02 ` [PATCH 6/6] mac80211: set basic rates earlier Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331223217.1598.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=m.sujith@gmail.com \
--cc=rmanohar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).