From: Joe Perches <joe@perches.com>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Amitkumar Karwar <akarwar@marvell.com>,
Kiran Divekar <dkiran@marvell.com>,
Yogesh Powar <yogeshp@marvell.com>,
Avinash Patil <patila@marvell.com>,
Frank Huang <frankh@marvell.com>
Subject: Re: [PATCH 10/15] mwifiex: fix checkpatch --strict warnings/errors Part 4
Date: Mon, 12 Mar 2012 19:52:15 -0700 [thread overview]
Message-ID: <1331607135.7100.4.camel@joe2Laptop> (raw)
In-Reply-To: <1331606291-322-1-git-send-email-bzhao@marvell.com>
On Mon, 2012-03-12 at 19:38 -0700, Bing Zhao wrote:
[]
> diff --git a/drivers/net/wireless/mwifiex/main.c b/drivers/net/wireless/mwifiex/main.c
[]
> @@ -495,7 +495,7 @@ mwifiex_set_mac_address(struct net_device *dev, void *addr)
> memcpy(priv->netdev->dev_addr, priv->curr_addr, ETH_ALEN);
> else
> dev_err(priv->adapter->dev, "set mac address failed: ret=%d"
> - "\n", ret);
> + "\n", ret);
Feel free to exceed 80 columns for formats.
This would be much more readable by coalescing the
formats like either of:
dev_err(priv->adapter->dev, "set mac address failed: ret=%d\n",
ret);
or
dev_err(priv->adapter->dev,
"set mac address failed: ret=%d\n", ret);
[]
> diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex/pcie.c
[]
> @@ -391,15 +391,16 @@ static int mwifiex_pcie_create_txbd_ring(struct mwifiex_adapter *adapter)
> card->txbd_ring_pbase = virt_to_phys(card->txbd_ring_vbase);
>
> dev_dbg(adapter->dev, "info: txbd_ring - base: %p, pbase: %#x:%x,"
> - "len: %x\n", card->txbd_ring_vbase,
> - (u32)card->txbd_ring_pbase,
> - (u32)((u64)card->txbd_ring_pbase >> 32),
> - card->txbd_ring_size);
> + "len: %x\n", card->txbd_ring_vbase,
> + (u32)card->txbd_ring_pbase,
> + (u32)((u64)card->txbd_ring_pbase >> 32),
> + card->txbd_ring_size);
etc...
next prev parent reply other threads:[~2012-03-13 2:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 2:38 [PATCH 10/15] mwifiex: fix checkpatch --strict warnings/errors Part 4 Bing Zhao
2012-03-13 2:38 ` [PATCH 11/15] mwifiex: fix checkpatch --strict warnings/errors Part 5 Bing Zhao
2012-03-13 2:38 ` [PATCH 12/15] mwifiex: fix checkpatch --strict warnings/errors Part 6 Bing Zhao
2012-03-13 2:38 ` [PATCH 13/15] mwifiex: fix checkpatch --strict warnings/errors Part 7 Bing Zhao
2012-03-13 2:38 ` [PATCH 14/15] mwifiex: fix checkpatch --strict warnings/errors Part 8 Bing Zhao
2012-03-13 2:38 ` [PATCH 15/15] mwifiex: fix checkpatch --strict warnings/errors Part 9 Bing Zhao
2012-03-13 2:52 ` Joe Perches [this message]
2012-03-13 3:06 ` [PATCH 10/15] mwifiex: fix checkpatch --strict warnings/errors Part 4 Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331607135.7100.4.camel@joe2Laptop \
--to=joe@perches.com \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=dkiran@marvell.com \
--cc=frankh@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=patila@marvell.com \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox