From: Johannes Berg <johannes@sipsolutions.net>
To: John Linville <linville@tuxdriver.com>
Cc: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] rndis_wlan: don't report station signal
Date: Thu, 15 Mar 2012 15:13:25 +0100 [thread overview]
Message-ID: <1331820805.3432.17.camel@jlt3.sipsolutions.net> (raw)
From: Johannes Berg <johannes.berg@intel.com>
The station signal value is supposed to be in dBm
which the device can't give, so don't report it.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
drivers/net/wireless/rndis_wlan.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
--- a/drivers/net/wireless/rndis_wlan.c 2012-03-10 09:17:00.000000000 +0100
+++ b/drivers/net/wireless/rndis_wlan.c 2012-03-15 15:11:52.000000000 +0100
@@ -2505,7 +2505,7 @@ static int rndis_set_default_key(struct
static void rndis_fill_station_info(struct usbnet *usbdev,
struct station_info *sinfo)
{
- __le32 linkspeed, rssi;
+ __le32 linkspeed;
int ret, len;
memset(sinfo, 0, sizeof(*sinfo));
@@ -2516,13 +2516,6 @@ static void rndis_fill_station_info(stru
sinfo->txrate.legacy = le32_to_cpu(linkspeed) / 1000;
sinfo->filled |= STATION_INFO_TX_BITRATE;
}
-
- len = sizeof(rssi);
- ret = rndis_query_oid(usbdev, OID_802_11_RSSI, &rssi, &len);
- if (ret == 0) {
- sinfo->signal = level_to_qual(le32_to_cpu(rssi));
- sinfo->filled |= STATION_INFO_SIGNAL;
- }
}
static int rndis_get_station(struct wiphy *wiphy, struct net_device *dev,
next reply other threads:[~2012-03-15 14:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 14:13 Johannes Berg [this message]
2012-03-15 14:25 ` [PATCH] rndis_wlan: don't report station signal John W. Linville
2012-03-15 14:47 ` Johannes Berg
2012-03-15 15:03 ` John W. Linville
2012-03-15 15:26 ` Johannes Berg
2012-03-15 15:58 ` John W. Linville
2012-03-15 15:58 ` [PATCH] cfg80211: allow CFG80211_SIGNAL_TYPE_UNSPEC in station_info John W. Linville
2012-03-15 16:19 ` Cristian Morales Vega
2012-03-15 16:26 ` Larry Finger
2012-03-15 16:33 ` Johannes Berg
2012-03-15 17:25 ` [PATCH v2] " John W. Linville
2012-03-15 17:33 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331820805.3432.17.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).