From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] cfg80211: allow CFG80211_SIGNAL_TYPE_UNSPEC in station_info
Date: Thu, 15 Mar 2012 17:33:42 +0100 [thread overview]
Message-ID: <1331829222.3432.27.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1331827087-21339-1-git-send-email-linville@tuxdriver.com>
On Thu, 2012-03-15 at 11:58 -0400, John W. Linville wrote:
> The station_info struct had demanded dBm signal values, but the
> cfg80211 wireless extensions implementation was also accepting
> "unspecified" (i.e. RSSI) unit values while the nl80211 code was
> completely unaware of them. Resolve this by formalling allowing the
> "unspecified" units while making nl80211 ignore them.
Looks fine, just a minor comment below.
> + * @signal: the signal strength, type depends on the wiphy's signal_type
> + * @signal_avg: avg signal strength, type depends on the wiphy's signal_type
This should be more specific since the BSS signal is "unspec" or "mBm"
where this now demands "unspec" or "dBm"... I suppose it could be made
more consistent at some point.
johannes
next prev parent reply other threads:[~2012-03-15 16:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 14:13 [PATCH] rndis_wlan: don't report station signal Johannes Berg
2012-03-15 14:25 ` John W. Linville
2012-03-15 14:47 ` Johannes Berg
2012-03-15 15:03 ` John W. Linville
2012-03-15 15:26 ` Johannes Berg
2012-03-15 15:58 ` John W. Linville
2012-03-15 15:58 ` [PATCH] cfg80211: allow CFG80211_SIGNAL_TYPE_UNSPEC in station_info John W. Linville
2012-03-15 16:19 ` Cristian Morales Vega
2012-03-15 16:26 ` Larry Finger
2012-03-15 16:33 ` Johannes Berg [this message]
2012-03-15 17:25 ` [PATCH v2] " John W. Linville
2012-03-15 17:33 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331829222.3432.27.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).