Re: [RFC 2/3] mac80211: protect ->scanning by mutex in ieee80211_work_work()

[Johannes Berg <johannes@sipsolutions.net>]

I don't really see the point in this. It seems that this doesn't really
help, you'd actually have to protect all the work stuff here with the
mutex so the scanning can also be excluded or so?

johannes

On Fri, 2012-03-16 at 13:02 +0100, Stanislaw Gruszka wrote:
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
>  net/mac80211/work.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/net/mac80211/work.c b/net/mac80211/work.c
> index 1f74af3..b2650a9 100644
> --- a/net/mac80211/work.c
> +++ b/net/mac80211/work.c
> @@ -122,9 +122,6 @@ static void ieee80211_work_work(struct work_struct *work)
>  	enum work_action rma;
>  	bool remain_off_channel = false;
>  
> -	if (local->scanning)
> -		return;
> -
>  	/*
>  	 * ieee80211_queue_work() should have picked up most cases,
>  	 * here we'll pick the rest.
> @@ -134,6 +131,11 @@ static void ieee80211_work_work(struct work_struct *work)
>  
>  	mutex_lock(&local->mtx);
>  
> +	if (local->scanning) {
> +		mutex_unlock(&local->mtx);
> +		return;
> +	}
> +
>  	ieee80211_recalc_idle(local);
>  
>  	list_for_each_entry_safe(wk, tmp, &local->work_list, list) {