From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] mac80211: fix possible tid_rx->reorder_timer use after free
Date: Mon, 19 Mar 2012 14:49:54 +0100 [thread overview]
Message-ID: <1332164994.3359.36.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20120319134259.GD6169@redhat.com>
On Mon, 2012-03-19 at 14:43 +0100, Stanislaw Gruszka wrote:
> On Mon, Mar 19, 2012 at 02:07:57PM +0100, Johannes Berg wrote:
> > I was actually thinking of using just del_timer(), but now that I think
> > about it, should anything prevent us from using del_timer_sync() inside
> > ieee80211_free_tid_rx?
>
> Yes, call_rcu() callback can not sleep. Depending of RCU implementation
> callback can run with bottom half disabled.
del_timer_sync() doesn't really *sleep* though, even if it waits, so it
should be fine?
johannes
next prev parent reply other threads:[~2012-03-19 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 12:50 [RFC] mac80211: fix possible tid_rx->reorder_timer use after free Stanislaw Gruszka
2012-03-19 13:03 ` Johannes Berg
2012-03-19 13:07 ` Johannes Berg
2012-03-19 13:43 ` Stanislaw Gruszka
2012-03-19 13:49 ` Johannes Berg [this message]
2012-03-19 13:57 ` Stanislaw Gruszka
2012-03-19 13:40 ` Stanislaw Gruszka
2012-03-19 13:50 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332164994.3359.36.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).