From: Johannes Berg <johannes@sipsolutions.net>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: inform the offchannel status to AP if no powersave
Date: Mon, 26 Mar 2012 18:09:11 +0200 [thread overview]
Message-ID: <1332778151.5435.44.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1332775418-16865-1-git-send-email-rmanohar@qca.qualcomm.com>
On Mon, 2012-03-26 at 20:53 +0530, Rajkumar Manoharan wrote:
> The station has to inform the offchannel status to the assiociated AP
> while switching b/w oper and off-channel. The station uses pspoll to
Gee, ok, I thought you meant "bandwidth", not "between". Might be worth
not being so lazy in the commit log ...
> fetch the buffered data from the AP and the pspoll frame can only be
> used when the powersave is enabled. For non-PS case, the station has
> to use nullfunc frame notification. Fix that.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
> ---
> net/mac80211/offchannel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/mac80211/offchannel.c b/net/mac80211/offchannel.c
> index f054e94..f7aedfc 100644
> --- a/net/mac80211/offchannel.c
> +++ b/net/mac80211/offchannel.c
> @@ -129,7 +129,7 @@ void ieee80211_offchannel_stop_vifs(struct ieee80211_local *local,
>
> if (sdata->vif.type != NL80211_IFTYPE_MONITOR) {
> netif_tx_stop_all_queues(sdata->dev);
> - if (offchannel_ps_enable &&
> + if ((offchannel_ps_enable || !sdata->u.mgd.powersave) &&
I'm not sure I like evaluating u.mgd.powersave before we even know it's
a managed interface ... not a huge issue though.
> (sdata->vif.type == NL80211_IFTYPE_STATION) &&
> sdata->u.mgd.associated)
> ieee80211_offchannel_ps_enable(sdata, true);
> @@ -152,7 +152,7 @@ void ieee80211_offchannel_return(struct ieee80211_local *local,
> continue;
>
> /* Tell AP we're back */
> - if (offchannel_ps_disable &&
> + if ((offchannel_ps_disable || !sdata->u.mgd.powersave) &&
> sdata->vif.type == NL80211_IFTYPE_STATION) {
> if (sdata->u.mgd.associated)
> ieee80211_offchannel_ps_disable(sdata);
Overall though I don't get it. u.mgd.powersave has nothing to do with
the current powersave state at all, it's just whether cfg80211 requested
powersave mode or not -- so NACK.
johannes
next prev parent reply other threads:[~2012-03-26 16:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 15:23 [PATCH 1/2] mac80211: inform the offchannel status to AP if no powersave Rajkumar Manoharan
2012-03-26 15:23 ` [PATCH 2/2] mac80211: fix oper channel timestamp updation Rajkumar Manoharan
2012-03-26 16:09 ` Johannes Berg
2012-03-26 21:37 ` Helmut Schaa
2012-03-26 16:09 ` Johannes Berg [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-26 15:23 [PATCH 1/2] mac80211: inform the offchannel status to AP if no powersave Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332778151.5435.44.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanohar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).