From: Luciano Coelho <coelho@ti.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Jouni Malinen <j@w1.fi>, Sujith <Sujith.Manoharan@atheros.com>,
Christian Lamparter <chunkeey@googlemail.com>,
"Luis R. Rodriguez" <mcgrof@gmail.com>
Subject: Re: [PATCH] mac80211: don't always advertise remain-on-channel
Date: Mon, 26 Mar 2012 23:10:50 +0300 [thread overview]
Message-ID: <1332792650.1347.27.camel@cumari> (raw)
In-Reply-To: <1332780438.5435.53.camel@jlt3.sipsolutions.net>
On Mon, 2012-03-26 at 18:47 +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Not all devices are really capable of implementing
> remain-on-channel, even if it is implemented in SW,
> as they can't necessarily deal with channel changes
> while associated.
>
> Remove the WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL and add
> it only if either the driver has remain_on_channel
> implemented in the driver/device.
>
> Also add it to all drivers that advertise P2P right
> now since those definitely have to have it working.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> I think e.g. wl1251 would completely get fucked up by this .. let's not
> go there. Also iwlegacy wouldn't like offchannel much, and doesn't need
> it since it'll never have P2P anyway.
Yes, I'm pretty sure it wouldn't work as is with wl1251. So, let's
leave it out.
Otherwise, for the wl12xx part:
Acked-by: Luciano Coelho <coelho@ti.com>
--
Cheers,
Luca.
prev parent reply other threads:[~2012-03-26 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 16:47 [PATCH] mac80211: don't always advertise remain-on-channel Johannes Berg
2012-03-26 20:10 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332792650.1347.27.camel@cumari \
--to=coelho@ti.com \
--cc=Sujith.Manoharan@atheros.com \
--cc=chunkeey@googlemail.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox