From: Johannes Berg <johannes@sipsolutions.net>
To: Timo Lindhorst <tlnd@online.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, Jouni Malinen <j@w1.fi>
Subject: Re: [PATCH] mac80211_hwsim: Report rate info in tx status
Date: Wed, 28 Mar 2012 11:28:26 +0200 [thread overview]
Message-ID: <1332926906.3479.22.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <201203281117.53033.tlnd@online.de>
On Wed, 2012-03-28 at 11:17 +0200, Timo Lindhorst wrote:
>
> + if (!ack)
> + for (i = 0; i < IEEE80211_TX_MAX_RATES; i++)
> + tx_count[i] = txi->control.rates[i].count;
> +
> +
> + if (ack) {
...
> + } else {
> + for (i = 0; i < IEEE80211_TX_MAX_RATES; i++)
> + txi->control.rates[i].count = tx_count[i];
> + }
I don't think I understand why you're copying the same data over itself?
johannes
next prev parent reply other threads:[~2012-03-28 9:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 9:17 [PATCH] mac80211_hwsim: Report rate info in tx status Timo Lindhorst
2012-03-28 9:28 ` Johannes Berg [this message]
2012-03-28 9:28 ` Timo Lindhorst
2012-03-28 9:32 ` Johannes Berg
2012-03-28 13:47 ` Timo Lindhorst
2012-04-30 18:34 ` John W. Linville
2012-05-03 19:33 ` Johannes Berg
2012-05-03 21:34 ` Javier Cardona
2012-05-07 23:17 ` Javier Cardona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332926906.3479.22.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tlnd@online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).