From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] compat: crc8: undef pr_fmt
Date: Fri, 30 Mar 2012 14:28:30 +0200 [thread overview]
Message-ID: <1333110510.12545.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4F75A3B8.7040501@broadcom.com>
On Fri, 2012-03-30 at 14:14 +0200, Arend van Spriel wrote:
> On 03/30/2012 01:54 PM, Johannes Berg wrote:
> > On Fri, 2012-03-30 at 13:49 +0200, Arend van Spriel wrote:
> >> On 03/30/2012 01:13 PM, Johannes Berg wrote:
> >>>
> >>> +#ifdef pr_fmt
> >>> +#undef pr_fmt
> >>> +#endif
> >>> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> >>>
> >>> #include<linux/module.h>
> >>
> >> Trivial remark. Not really necessary to do the #ifdef. #undef works fine
> >> if pr_fmt has not been defined.
> >
> > Really? I thought it would give a warning then, but couldn't test it
> > since it was defined for me.
> >
> > johannes
> >
> >
>
> I made a little test program to confirm my thought, before sending my
> previous email. Retried compiling with '-W -Wall -ansi -pedantic' and no
> complaints about the #undef.
Ok. I'm too lazy to send a new patch, but maybe Luis wants to change it
when he applies it :)
johannes
next prev parent reply other threads:[~2012-03-30 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 11:13 [PATCH] compat: crc8: undef pr_fmt Johannes Berg
2012-03-30 11:49 ` Arend van Spriel
2012-03-30 11:54 ` Johannes Berg
2012-03-30 12:14 ` Arend van Spriel
2012-03-30 12:28 ` Johannes Berg [this message]
2012-03-30 21:23 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333110510.12545.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).