From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] compat: explicitly export generated variables
Date: Fri, 30 Mar 2012 22:34:02 +0200 [thread overview]
Message-ID: <1333139642.7679.7.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAB=NE6XXzwKjFCbV=zi7DaPtpa4aqttB4EMTqaKSzhPMHwJd1A@mail.gmail.com> (sfid-20120330_223142_126396_7FBFC053)
On Fri, 2012-03-30 at 13:30 -0700, Luis R. Rodriguez wrote:
> On Fri, Mar 30, 2012 at 4:11 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > Doing the blanket "export" statement at the beginning
> > of the generated file confuses the kernel's Makefiles
> > and causes extreme build slowdowns.
> >
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> > ---
>
> Nice, how did you figure this out BTW!?
Random monkey approach ;-)
I noticed it was slow and saw that it was due to some weird shit from
the kernel Makefile.lib being executed when it shouldn't be.
Since I have the compat *result* in git, I could easily see the diff
between the old compat.git/compat-wireless.git and the new versions. And
then I basically tried to identify the changes that caused this problem,
my best guess was that it had to be the Makefile so I gradually changed
that back to the previous version until the problem went away ... and
then identified which changes were responsible.
johannes
next prev parent reply other threads:[~2012-03-30 20:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 11:10 [PATCH 0/2] compat: fix extreme build slowdowns Johannes Berg
2012-03-30 11:11 ` [PATCH 1/2] compat-wireless: include config.mk early Johannes Berg
2012-03-30 11:11 ` [PATCH 2/2] compat: explicitly export generated variables Johannes Berg
2012-03-30 20:30 ` Luis R. Rodriguez
2012-03-30 20:34 ` Johannes Berg [this message]
2012-03-30 20:38 ` Luis R. Rodriguez
2012-03-30 11:26 ` [PATCH 0/2] compat: fix extreme build slowdowns Sujith Manoharan
2012-03-30 11:30 ` Johannes Berg
2012-03-30 14:41 ` Richard Farina
2012-03-30 20:43 ` Luis R. Rodriguez
2012-03-30 21:24 ` Luis R. Rodriguez
2012-03-30 21:48 ` Luis R. Rodriguez
2012-03-31 9:24 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333139642.7679.7.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).