From: Johannes Berg <johannes@sipsolutions.net>
To: Daniil Dulov <d.dulov@aladdin.ru>
Cc: Kees Cook <kees@kernel.org>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
Daniel Drake <dsd@gentoo.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] wifi: zd1211rw: Fix potential data race in zd_mac_tx_to_dev()
Date: Wed, 11 Jun 2025 11:35:18 +0200 [thread overview]
Message-ID: <13332646e4c8b028504f6a7ec4a2aa9530c519f1.camel@sipsolutions.net> (raw)
In-Reply-To: <20250604101356.6292-1-d.dulov@aladdin.ru>
Hi,
So ... I have no idea why you're CC'ing all kinds of people who never
had anything to do with this driver, or haven't worked on WiFi in like a
decade or so ... Please don't. Even I should've been CC'ed with a
different address, at most.
I also have no idea who's maintaining this driver now though, if anyone.
I have hardware if someone wants it ;-)
> In order to avoid potential data races and leading dereference of a NULL
> pointer, acquire the queue lock before any work with the queue is done and
> replace all skb_* calls with their lockless version.
You should explain why the locking changes are OK.
johannes
next prev parent reply other threads:[~2025-06-11 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 10:13 [PATCH] wifi: zd1211rw: Fix potential data race in zd_mac_tx_to_dev() Daniil Dulov
2025-06-11 9:35 ` Johannes Berg [this message]
2025-06-16 12:36 ` Daniil Dulov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13332646e4c8b028504f6a7ec4a2aa9530c519f1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=d.dulov@aladdin.ru \
--cc=dsd@gentoo.org \
--cc=emmanuel.grumbach@intel.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lvc-project@linuxtesting.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox