From: Johannes Berg <johannes@sipsolutions.net>
To: Eliad Peller <eliad@wizery.com>
Cc: John Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: add explicit monitor interface if needed
Date: Tue, 03 Apr 2012 14:34:40 +0200 [thread overview]
Message-ID: <1333456480.3574.16.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAB3XZEfmBT724sP_3=pmBQixy1eW_x7V9_jsJi0cmWHJvogfVg@mail.gmail.com> (sfid-20120403_142254_537328_9F55F074)
On Tue, 2012-04-03 at 15:22 +0300, Eliad Peller wrote:
> > @@ -266,6 +319,12 @@ static int ieee80211_do_open(struct net_
> > break;
> > }
> >
> > + if (local->monitors == 0 && local->open_count == 0) {
> > + res = ieee80211_add_virtual_monitor(local);
> > + if (res)
> > + return res;
>
> you probably have to goto instead (to clean up properly - drv_stop etc.).
Hm, good catch, this is a bit confusing. I'll do that, and then post
another patch to clean up the error paths a bit.
johannes
next prev parent reply other threads:[~2012-04-03 12:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 8:24 [PATCH 0/2] queue mapping changes Johannes Berg
2012-04-03 8:29 ` [PATCH 1/2] mac80211: add explicit monitor interface if needed Johannes Berg
2012-04-03 12:22 ` Eliad Peller
2012-04-03 12:34 ` Johannes Berg [this message]
2012-04-03 12:35 ` [PATCH v2 " Johannes Berg
2012-04-03 8:29 ` [PATCH 2/2] mac80211: add improved HW queue control Johannes Berg
2012-04-03 14:28 ` [PATCH v3 " Johannes Berg
2012-04-12 10:19 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333456480.3574.16.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).