linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Thomas Pedersen <c_tpeder@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath6kl-devel@qualcomm.com
Subject: Re: [PATCH 2/2] ath6kl: handle concurrent AP-STA channel switches
Date: Wed, 04 Apr 2012 12:02:58 -0700	[thread overview]
Message-ID: <1333566178.16978.29.camel@joe2Laptop> (raw)
In-Reply-To: <1333565817-18816-2-git-send-email-c_tpeder@qca.qualcomm.com>

On Wed, 2012-04-04 at 11:56 -0700, Thomas Pedersen wrote:
> If an ath6kl AP vif is beaconing on one channel, and a STA vif
> associates on a different channel, a WMI_DISCONNECT event will be sent
> to the AP vif. Make the AP vif follow the STA interface, and notify
> userspace.

trivia:

> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
[]
> @@ -1015,6 +1015,19 @@ out:
>  	vif->scan_req = NULL;
>  }
>  
> +void ath6kl_cfg80211_ch_switch_notify(struct ath6kl_vif *vif, int channel,
> +				      enum wmi_phy_mode mode)
> +{
> +	enum nl80211_channel_type type;
> +
> +	ath6kl_dbg(ATH6KL_DBG_WLAN_CFG, "channel switch notify nw_type %d"
> +		   "freq %d mode %d", vif->nw_type, channel, mode);

Please coalesce formats.
If you had, you'd've seen a problem with this format.
Add a newline "\n" terminator to it too.


  reply	other threads:[~2012-04-04 19:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-04 18:56 [PATCH 1/2] cfg80211: add channel switch notify event Thomas Pedersen
2012-04-04 18:56 ` [PATCH 2/2] ath6kl: handle concurrent AP-STA channel switches Thomas Pedersen
2012-04-04 19:02   ` Joe Perches [this message]
2012-04-04 20:00     ` Pedersen, Thomas
2012-04-04 20:09       ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333566178.16978.29.camel@joe2Laptop \
    --to=joe@perches.com \
    --cc=ath6kl-devel@qualcomm.com \
    --cc=c_tpeder@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).