From: Joe Perches <joe@perches.com>
To: "Pedersen, Thomas" <c_tpeder@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath6kl-devel@qualcomm.com
Subject: Re: [PATCH 2/2] ath6kl: handle concurrent AP-STA channel switches
Date: Wed, 04 Apr 2012 13:09:08 -0700 [thread overview]
Message-ID: <1333570148.23520.18.camel@joe2Laptop> (raw)
In-Reply-To: <20120404200008.GA19758@pista>
On Wed, 2012-04-04 at 13:00 -0700, Pedersen, Thomas wrote:
> > > + ath6kl_dbg(ATH6KL_DBG_WLAN_CFG, "channel switch notify nw_type %d"
> > > + "freq %d mode %d", vif->nw_type, channel, mode);
> >
> > Please coalesce formats.
> > If you had, you'd've seen a problem with this format.
> > Add a newline "\n" terminator to it too.
>
> I'm not sure what you mean by "coalesce formats". The freq / channel
> semantic mismatch? I'll change that and add a newline as well.
There's currently no space between a "%d" and "freq".
There should be one. It'd be better and less error
prone like this:
ath6kl_dbg(ATH6KL_DBG_WLAN_CFG,
"channel switch notify nw_type %d freq %d mode %d\n",
vif->nw_type, channel, mode);
cheers, Joe
prev parent reply other threads:[~2012-04-04 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 18:56 [PATCH 1/2] cfg80211: add channel switch notify event Thomas Pedersen
2012-04-04 18:56 ` [PATCH 2/2] ath6kl: handle concurrent AP-STA channel switches Thomas Pedersen
2012-04-04 19:02 ` Joe Perches
2012-04-04 20:00 ` Pedersen, Thomas
2012-04-04 20:09 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333570148.23520.18.camel@joe2Laptop \
--to=joe@perches.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=c_tpeder@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox