From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 5/6] mac80211: Add more ethtools stats: survey, rates, etc
Date: Tue, 17 Apr 2012 18:41:40 -0700 [thread overview]
Message-ID: <1334713300.3725.18.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1334684807-14026-6-git-send-email-greearb@candelatech.com> (sfid-20120417_194713_443684_C3723CAF)
On Tue, 2012-04-17 at 10:46 -0700, greearb@candelatech.com wrote:
> + /* Get survey stats for current channel */
> + survey.filled = 0;
> + if (drv_get_survey(local, 0, &survey) != 0) {
> + survey.filled = 0;
> + data[i++] = 0;
> + } else {
> + /* ath9k (and maybe others??) only updates internal stats
> + * when you get channel index 0, so if
> + * we are NOT on channel zero, get the real stats
> + * now.
> + */
> + int ch_idx = ieee80211_get_channel_idx(local->hw.wiphy,
> + local->oper_channel->center_freq);
> + if (ch_idx == 0) {
> + data[i++] = survey.channel->center_freq;
> + } else {
> + survey.filled = 0;
> + if (drv_get_survey(local, ch_idx, &survey) != 0) {
> + survey.filled = 0;
> + data[i++] = 0;
> + } else {
> + data[i++] = survey.channel->center_freq;
> + }
> + }
> + }
This is completely incomprehensible to me. I don't think the channel
index is what you think it is?
johannes
next prev parent reply other threads:[~2012-04-18 1:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 17:46 [PATCH v2 0/6] Add ethtool stats support for Wireless Devices greearb
2012-04-17 17:46 ` [PATCH v2 1/6] cfg80211: Add framework to support ethtool stats greearb
2012-04-17 17:46 ` [PATCH v2 2/6] mac80211: Support getting sta_info stats via ethtool greearb
2012-04-18 1:37 ` Johannes Berg
2012-04-18 3:46 ` Ben Greear
2012-04-18 4:00 ` Johannes Berg
2012-04-18 16:27 ` Ben Greear
2012-04-18 22:39 ` Johannes Berg
2012-04-18 22:59 ` Ben Greear
2012-04-19 4:38 ` Johannes Berg
2012-04-17 17:46 ` [PATCH v2 3/6] mac80211: Framework to get wifi-driver " greearb
2012-04-17 17:46 ` [PATCH v2 4/6] wireless: Add util method to get channel index from frequency greearb
2012-04-18 1:40 ` Johannes Berg
2012-04-18 3:36 ` Ben Greear
2012-04-17 17:46 ` [PATCH v2 5/6] mac80211: Add more ethtools stats: survey, rates, etc greearb
2012-04-18 1:41 ` Johannes Berg [this message]
2012-04-18 3:31 ` Ben Greear
2012-04-18 4:05 ` Johannes Berg
2012-04-18 16:19 ` Ben Greear
2012-04-18 22:40 ` Johannes Berg
2012-04-18 22:54 ` Ben Greear
2012-04-19 4:37 ` Johannes Berg
2012-04-17 17:46 ` [PATCH v2 6/6] mac80211: Add sta_state to ethtool stats greearb
2012-04-18 1:42 ` Johannes Berg
2012-04-18 1:44 ` [PATCH v2 0/6] Add ethtool stats support for Wireless Devices Johannes Berg
2012-04-18 3:56 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334713300.3725.18.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).