Re: [PATCH v2 0/6] Add ethtool stats support for Wireless Devices

[Johannes Berg <johannes@sipsolutions.net>]

On Tue, 2012-04-17 at 10:46 -0700, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> 
> This enables ethtool stats for mac80211 devices.  It also
> adds hooks to call down into mac80211 drivers for additional
> stats.  Patches to enable this hook in ath9k will be posted
> in a different series.
> 
> There was a review question about how to make the ethtool
> strings line up with the data in a less error prone manner.
> This patch series does NOT address that.  I think it may
> be more work than it's worth to try to do this, but we
> can always retro-fit such behaviour later if desired.
> Many drivers have this issue, so perhaps some support
> code in the ethtool core is the way to go.
> 
> V2:  Fix getting survey stats:  Need to specify the
>   current channel index, not just use index zero.  The
>   fix for this involved adding a new helper method which
>   adds a patch to the series.

I'm in training all day tomorrow, and then I'll make my way home only to
go on vacation this weekend, for two weeks.

Would you mind holding all of this until I return from vacation? There
are some issues with this where at least one of us has a total
misunderstanding about how some things work. TBH, it could be me because
I'm not very familiar with the survey code.

johannes