From: "Franky Lin" <frankyl@broadcom.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 3.4 1/2] brcm80211: fmac: fix SDIO function 0 register r/w issue
Date: Fri, 20 Apr 2012 14:27:48 -0700 [thread overview]
Message-ID: <1334957269-27416-2-git-send-email-frankyl@broadcom.com> (raw)
In-Reply-To: <1334957269-27416-1-git-send-email-frankyl@broadcom.com>
SDIO stack doesn't have a structure for function 0. The structure
pointer stored in card->sdio_func[0] is actually for function 1.
With current implementation the register read/write is applied to
function 1. This pathch fixes the issue.
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
---
.../net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
index 4688904..6989916 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
@@ -108,9 +108,13 @@ static inline int brcmf_sdioh_f0_write_byte(struct brcmf_sdio_dev *sdiodev,
sdio_release_host(sdfunc);
}
} else if (regaddr == SDIO_CCCR_ABORT) {
+ sdfunc = kzalloc(sizeof(struct sdio_func), GFP_KERNEL);
+ memcpy(sdfunc, sdiodev->func[0], sizeof(struct sdio_func));
+ sdfunc->num = 0;
sdio_claim_host(sdfunc);
sdio_writeb(sdfunc, *byte, regaddr, &err_ret);
sdio_release_host(sdfunc);
+ kfree(sdfunc);
} else if (regaddr < 0xF0) {
brcmf_dbg(ERROR, "F0 Wr:0x%02x: write disallowed\n", regaddr);
err_ret = -EPERM;
@@ -486,7 +490,7 @@ static int brcmf_ops_sdio_probe(struct sdio_func *func,
kfree(bus_if);
return -ENOMEM;
}
- sdiodev->func[0] = func->card->sdio_func[0];
+ sdiodev->func[0] = func;
sdiodev->func[1] = func;
sdiodev->bus_if = bus_if;
bus_if->bus_priv.sdio = sdiodev;
--
1.7.5.4
next prev parent reply other threads:[~2012-04-20 21:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 21:27 [PATCH 3.4 0/2] brcm80211: two fullmac bug fix for 3.4 Franky Lin
2012-04-20 21:27 ` Franky Lin [this message]
2012-04-23 8:45 ` [PATCH 3.4 1/2] brcm80211: fmac: fix SDIO function 0 register r/w issue Florian Fainelli
2012-04-23 8:50 ` Johannes Berg
2012-04-23 17:45 ` Franky Lin
2012-04-20 21:27 ` [PATCH 3.4 2/2] brcm80211: fmac: fix missing completion events issue Franky Lin
2012-04-23 21:24 ` [PATCH 3.4 V2 0/2] brcm80211: two fullmac bug fix for 3.4 Franky Lin
2012-04-23 21:24 ` [PATCH 3.4 V2 1/2] brcm80211: fmac: fix SDIO function 0 register r/w issue Franky Lin
2012-04-23 21:24 ` [PATCH 3.4 V2 2/2] brcm80211: fmac: fix missing completion events issue Franky Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334957269-27416-2-git-send-email-frankyl@broadcom.com \
--to=frankyl@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).