From: "Franky Lin" <frankyl@broadcom.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 1/4] brcmfmac: stop releasing sdio host in irq handler
Date: Fri, 27 Apr 2012 18:56:56 -0700 [thread overview]
Message-ID: <1335578219-4224-2-git-send-email-frankyl@broadcom.com> (raw)
In-Reply-To: <1335578219-4224-1-git-send-email-frankyl@broadcom.com>
brcmf_sdbrcm_isr doesn't access to the dongle through SDIO bus.
Stop releasing and claiming host in irq handler to eliminate
any potential risk.
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
---
drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
index e925290..ea35020 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
@@ -45,11 +45,7 @@ static void brcmf_sdioh_irqhandler(struct sdio_func *func)
brcmf_dbg(TRACE, "***IRQHandler\n");
- sdio_release_host(func);
-
brcmf_sdbrcm_isr(sdiodev->bus);
-
- sdio_claim_host(func);
}
/* dummy handler for SDIO function 2 interrupt */
--
1.7.9.5
next prev parent reply other threads:[~2012-04-28 1:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 1:56 [PATCH 0/4] brcmfmac: introducing out of band interrupt support Franky Lin
2012-04-28 1:56 ` Franky Lin [this message]
2012-04-28 1:56 ` [PATCH 2/4] brcmfmac: check bus state for status Franky Lin
2012-04-28 1:56 ` [PATCH 3/4] brcmfmac: postpone interrupt register function Franky Lin
2012-04-28 1:56 ` [PATCH 4/4] brcmfmac: add out of band interrupt support Franky Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335578219-4224-2-git-send-email-frankyl@broadcom.com \
--to=frankyl@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).