Re: [RFC 0/9] compat-wireless: restructure header files in compat

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2012-04-26 at 20:07 +0200, Hauke Mehrtens wrote:
> The patch series moves the compat code from include/linux/compat-*.h 
> into new files with the same name as the file where this code is placed 
> in the mainline kernel. With this approach we do not have to include 
> all include/linux/compat-*.h files in the build process any more, but 
> we extend the existing header files by the code needed.
> 
> This compiles without any warnings for me with kernel 3.2 to 3.4 and 
> fixes the problems with pr_fmt() without the need of any patch.
> Sometimes I had problems compiling compat-wireless, because some header 
> file I would not like to include was included because of compat-2.6.h 
> included mostly every header file available in the kernel.
> 
> This patch series is only done to support kernel >= 3.2, supporting the 
> other versions is just more work, but I want to have some responses on 
> this first. There are probably some other problems and some more 
> cleanup is possible.
> In the end we will remove the include/linux/compat-*.h files.
> 
> I have a problem where compat does changes to header files provided by 
> compat-wireless like #define NL80211_FEATURE_SK_TX_STATUS 0 in compat-
> 2.6.33.h. To make this work we should add an other include directory in 
> compat-wireless.
> The hierarchy of include directories should be this: 1. include dir 
> from compat, 2. include dir from compat-wireless, 3. the kernel include 
> dir, now the 1. and the 2. are but into one directory.


I think this is worthwhile. There may be some issues with it,
particularly when header files are renamed, but I think those can be
solved relatively easily, like we already did with tracing.

johannes