Re: [RFC c-w 2/4] compat-wireless: also copy include/generated/ from compat

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2012-05-03 at 21:05 +0200, Hauke Mehrtens wrote:
> On 05/03/2012 08:57 PM, Johannes Berg wrote:
> > On Thu, 2012-04-26 at 20:07 +0200, Hauke Mehrtens wrote:
> >> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> >> ---
> >>  scripts/admin-update.sh |    2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/scripts/admin-update.sh b/scripts/admin-update.sh
> >> index fd1fa87..7147ff1 100755
> >> --- a/scripts/admin-update.sh
> >> +++ b/scripts/admin-update.sh
> >> @@ -283,6 +283,7 @@ mkdir -p include/linux/ include/net/ include/linux/usb \
> >>  	include/trace \
> >>  	include/pcmcia \
> >>  	include/crypto \
> >> +	include/generated \
> > 
> > Are you sure we want this? It seems to me that most generated things
> > like asm-offsets etc. need to be taken from the *target* kernel.
> 
> The directory include/generated/ in compat, just contains
> include/generated/autoconf.h, which will include linux/compat_autoconf.h
> and the original file from the kernel. This way the compat_autoconf.h
> will always be included when autoconf.h gets included.
> See "[RFC c 2/9] compat: include compat_autoconf.h"
> 
> I do not think there will be any other header in include/generated/ we
> want to extend or overwrite in compat.

Oh, this is copying from compat, not the base kernel, I got that
confused. Sorry!

johannes