linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ashok Nagarajan <ashok@cozybit.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
	javier@cozybit.com, devel@lists.open80211s.org
Subject: Re: [PATCH v2 1/4] mac80211: Advertise HT protection mode in IEs
Date: Thu, 03 May 2012 21:36:34 +0200	[thread overview]
Message-ID: <1336073794.5167.15.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1335820832-18887-1-git-send-email-ashok@cozybit.com> (sfid-20120430_232127_377222_6BE61350)

On Mon, 2012-04-30 at 14:20 -0700, Ashok Nagarajan wrote:

>  		pos = ieee80211_ie_build_ht_oper(pos, &sband->ht_cap,
> -						 chan, channel_type);
> +						 chan, channel_type, 0);

> -	/*
> -	 * Note: According to 802.11n-2009 9.13.3.1, HT Protection field and
> -	 * RIFS Mode are reserved in IBSS mode, therefore keep them at 0
> -	 */
> -	ht_oper->operation_mode = 0x0000;
> +	ht_oper->operation_mode = cpu_to_le16(prot_mode);

Please move the comment to the now correct place instead of deleting it.

johannes


  parent reply	other threads:[~2012-05-03 19:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-30 21:20 [PATCH v2 1/4] mac80211: Advertise HT protection mode in IEs Ashok Nagarajan
2012-04-30 21:20 ` [PATCH v2 2/4] mac80211: Implement HT mixed protection mode Ashok Nagarajan
2012-05-03 19:39   ` Johannes Berg
2012-05-03 20:21     ` Ashok Nagarajan
2012-04-30 21:20 ` [PATCH v2 3/4] mac80211: Allow nonHT/HT peering in mesh Ashok Nagarajan
2012-05-03 19:40   ` Johannes Berg
2012-05-03 20:23     ` Ashok Nagarajan
2012-05-03 20:29       ` Johannes Berg
2012-04-30 21:20 ` [PATCH v2 4/4] [nl,cfg,mac]80211: Allow user to see/configure HT protection mode Ashok Nagarajan
2012-05-03 19:36 ` Johannes Berg [this message]
2012-05-03 20:20   ` [PATCH v2 1/4] mac80211: Advertise HT protection mode in IEs Ashok Nagarajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336073794.5167.15.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ashok@cozybit.com \
    --cc=devel@lists.open80211s.org \
    --cc=javier@cozybit.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).