From: Johannes Berg <johannes@sipsolutions.net>
To: Ashok Nagarajan <ashok@cozybit.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
javier@cozybit.com, devel@lists.open80211s.org
Subject: Re: [PATCH v2 2/4] mac80211: Implement HT mixed protection mode
Date: Thu, 03 May 2012 21:39:22 +0200 [thread overview]
Message-ID: <1336073962.5167.18.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1335820832-18887-2-git-send-email-ashok@cozybit.com> (sfid-20120430_232128_748335_8B027146)
On Mon, 2012-04-30 at 14:20 -0700, Ashok Nagarajan wrote:
> +/** mesh_set_ht_prot_mode - set correct HT protection mode
I think you need a newline before the function name, but this isn't
really valid kernel-doc anyway so please just don't use **
> + *
> + * Section 9.23.3.5 of IEEE 80211s standard
There's no 80211s standard. 802.11s is an amendment, please correct the
reference to the -2012 version.
> + rcu_read_lock();
> + list_for_each_entry_rcu(sta, &local->sta_list, list) {
> + if (sdata == sta->sdata &&
> + sta->plink_state == NL80211_PLINK_ESTAB) {
there would be less indentation if you'd add a continue for the mismatch
cases :-)
johannes
next prev parent reply other threads:[~2012-05-03 19:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 21:20 [PATCH v2 1/4] mac80211: Advertise HT protection mode in IEs Ashok Nagarajan
2012-04-30 21:20 ` [PATCH v2 2/4] mac80211: Implement HT mixed protection mode Ashok Nagarajan
2012-05-03 19:39 ` Johannes Berg [this message]
2012-05-03 20:21 ` Ashok Nagarajan
2012-04-30 21:20 ` [PATCH v2 3/4] mac80211: Allow nonHT/HT peering in mesh Ashok Nagarajan
2012-05-03 19:40 ` Johannes Berg
2012-05-03 20:23 ` Ashok Nagarajan
2012-05-03 20:29 ` Johannes Berg
2012-04-30 21:20 ` [PATCH v2 4/4] [nl,cfg,mac]80211: Allow user to see/configure HT protection mode Ashok Nagarajan
2012-05-03 19:36 ` [PATCH v2 1/4] mac80211: Advertise HT protection mode in IEs Johannes Berg
2012-05-03 20:20 ` Ashok Nagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336073962.5167.18.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ashok@cozybit.com \
--cc=devel@lists.open80211s.org \
--cc=javier@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).