[PATCH 2/2] NFC: Select CRC_CCITT for SHDLC link layer of HCI based drivers

[PATCH 2/2] NFC: Select CRC_CCITT for SHDLC link layer of HCI based drivers

[Marcel Holtmann]

The SHDLC link layer of HCI based drivers uses CRC-CCITT and thus
needs to select that kernel option.

Otherwise it ends up with this linking error:

net/built-in.o: In function `nfc_shdlc_add_len_crc':
net/nfc/hci/shdlc.c:113: undefined reference to `crc_ccitt'

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
 net/nfc/hci/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/nfc/hci/Kconfig b/net/nfc/hci/Kconfig
index 17213a6..fd67f51 100644
--- a/net/nfc/hci/Kconfig
+++ b/net/nfc/hci/Kconfig
@@ -9,6 +9,7 @@ config NFC_HCI
 
 config NFC_SHDLC
 	depends on NFC_HCI
+	select CRC_CCITT
 	bool "SHDLC link layer for HCI based NFC drivers"
 	default n
 	---help---
-- 
1.7.7.6

Re: [PATCH 2/2] NFC: Select CRC_CCITT for SHDLC link layer of HCI based drivers

[John W. Linville]

Was there a [PATCH 1/2]?  I didn't get it...

On Thu, May 03, 2012 at 07:12:48AM +0200, Marcel Holtmann wrote:
> The SHDLC link layer of HCI based drivers uses CRC-CCITT and thus
> needs to select that kernel option.
> 
> Otherwise it ends up with this linking error:
> 
> net/built-in.o: In function `nfc_shdlc_add_len_crc':
> net/nfc/hci/shdlc.c:113: undefined reference to `crc_ccitt'
> 
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
>  net/nfc/hci/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/net/nfc/hci/Kconfig b/net/nfc/hci/Kconfig
> index 17213a6..fd67f51 100644
> --- a/net/nfc/hci/Kconfig
> +++ b/net/nfc/hci/Kconfig
> @@ -9,6 +9,7 @@ config NFC_HCI
>  
>  config NFC_SHDLC
>  	depends on NFC_HCI
> +	select CRC_CCITT
>  	bool "SHDLC link layer for HCI based NFC drivers"
>  	default n
>  	---help---
> -- 
> 1.7.7.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH 2/2] NFC: Select CRC_CCITT for SHDLC link layer of HCI based drivers

[Marcel Holtmann]

Hi John,

> Was there a [PATCH 1/2]?  I didn't get it...

yes, but it was a Bluetooth one :)

Regards

Marcel

Re: [PATCH 2/2] NFC: Select CRC_CCITT for SHDLC link layer of HCI based drivers

[Samuel Ortiz]

Hi Marcel,

On Thu, 2012-05-03 at 07:12 +0200, Marcel Holtmann wrote:
> The SHDLC link layer of HCI based drivers uses CRC-CCITT and thus
> needs to select that kernel option.
> 
> Otherwise it ends up with this linking error:
> 
> net/built-in.o: In function `nfc_shdlc_add_len_crc':
> net/nfc/hci/shdlc.c:113: undefined reference to `crc_ccitt'
> 
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>

Cheers,
Samuel.