[PATCH] cfg80211: Remove compile warnings

[PATCH] cfg80211: Remove compile warnings

[Andrei Emeltchenko]

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

Use default key to handle similar iface types. This removes compile warnings:

net/wireless/util.c: In function ‘cfg80211_change_iface’:
net/wireless/util.c:846:3: warning: enumeration value ‘NL80211_IFTYPE_MAX’
	not handled in switch [-Wswitch]

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
 net/wireless/util.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/wireless/util.c b/net/wireless/util.c
index 1b7a08d..468dc8b 100644
--- a/net/wireless/util.c
+++ b/net/wireless/util.c
@@ -862,8 +862,7 @@ int cfg80211_change_iface(struct cfg80211_registered_device *rdev,
 		case NL80211_IFTYPE_MONITOR:
 			/* monitor can't bridge anyway */
 			break;
-		case NL80211_IFTYPE_UNSPECIFIED:
-		case NUM_NL80211_IFTYPES:
+		default:
 			/* not happening */
 			break;
 		}
-- 
1.7.9.5

Re: [PATCH] cfg80211: Remove compile warnings

[Johannes Berg]

On Wed, 2012-04-25 at 15:45 +0300, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> 
> Use default key to handle similar iface types. This removes compile warnings:
> 
> net/wireless/util.c: In function ‘cfg80211_change_iface’:
> net/wireless/util.c:846:3: warning: enumeration value ‘NL80211_IFTYPE_MAX’
> 	not handled in switch [-Wswitch]
> 
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
>  net/wireless/util.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/wireless/util.c b/net/wireless/util.c
> index 1b7a08d..468dc8b 100644
> --- a/net/wireless/util.c
> +++ b/net/wireless/util.c
> @@ -862,8 +862,7 @@ int cfg80211_change_iface(struct cfg80211_registered_device *rdev,
>  		case NL80211_IFTYPE_MONITOR:
>  			/* monitor can't bridge anyway */
>  			break;
> -		case NL80211_IFTYPE_UNSPECIFIED:
> -		case NUM_NL80211_IFTYPES:
> +		default:

When did this warning start occurring? I was pretty sure it didn't use
to? I think we should explicitly list the cases here though because we
want the compiler to warn here when we add something to the interface
type list so we catch this place that may have to be modified.

johannes

Re: [PATCH] cfg80211: Remove compile warnings

[Andrei Emeltchenko]

Hi Johannes,

On Thu, May 3, 2012 at 10:00 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Wed, 2012-04-25 at 15:45 +0300, Andrei Emeltchenko wrote:
>> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>>
>> Use default key to handle similar iface types. This removes compile warnings:
>>
>> net/wireless/util.c: In function ‘cfg80211_change_iface’:
>> net/wireless/util.c:846:3: warning: enumeration value ‘NL80211_IFTYPE_MAX’
>>       not handled in switch [-Wswitch]
>>
>> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>> ---
>>  net/wireless/util.c |    3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/net/wireless/util.c b/net/wireless/util.c
>> index 1b7a08d..468dc8b 100644
>> --- a/net/wireless/util.c
>> +++ b/net/wireless/util.c
>> @@ -862,8 +862,7 @@ int cfg80211_change_iface(struct cfg80211_registered_device *rdev,
>>               case NL80211_IFTYPE_MONITOR:
>>                       /* monitor can't bridge anyway */
>>                       break;
>> -             case NL80211_IFTYPE_UNSPECIFIED:
>> -             case NUM_NL80211_IFTYPES:
>> +             default:
>
> When did this warning start occurring? I was pretty sure it didn't use
> to? I think we should explicitly list the cases here though because we
> want the compiler to warn here when we add something to the interface
> type list so we catch this place that may have to be modified.

I think warning occurs when I added new interface type since it is
also not handled.

Regards,
Andrei

Re: [PATCH] cfg80211: Remove compile warnings

[Johannes Berg]

On Fri, 2012-05-04 at 11:44 +0300, Andrei Emeltchenko wrote:

> >> -             case NL80211_IFTYPE_UNSPECIFIED:
> >> -             case NUM_NL80211_IFTYPES:
> >> +             default:
> >
> > When did this warning start occurring? I was pretty sure it didn't use
> > to? I think we should explicitly list the cases here though because we
> > want the compiler to warn here when we add something to the interface
> > type list so we catch this place that may have to be modified.
> 
> I think warning occurs when I added new interface type since it is
> also not handled.

Well, but in that case the warning is supposed to happen to tell you
that you need to think about that code for your new interface type.

John, please revert this patch.

johannes

Re: [PATCH] cfg80211: Remove compile warnings

[John W. Linville]

On Mon, May 07, 2012 at 11:30:24AM +0200, Johannes Berg wrote:
> On Fri, 2012-05-04 at 11:44 +0300, Andrei Emeltchenko wrote:
> 
> > >> -             case NL80211_IFTYPE_UNSPECIFIED:
> > >> -             case NUM_NL80211_IFTYPES:
> > >> +             default:
> > >
> > > When did this warning start occurring? I was pretty sure it didn't use
> > > to? I think we should explicitly list the cases here though because we
> > > want the compiler to warn here when we add something to the interface
> > > type list so we catch this place that may have to be modified.
> > 
> > I think warning occurs when I added new interface type since it is
> > also not handled.
> 
> Well, but in that case the warning is supposed to happen to tell you
> that you need to think about that code for your new interface type.
> 
> John, please revert this patch.

I'm having to do some rebasing to handle the bluetooth kerfuffle.
I'll simply drop this patch.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.