From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
John Linville <linville@tuxdriver.com>,
wireless <linux-wireless@vger.kernel.org>
Subject: Re: WARNING: at net/mac80211/iface.c:162
Date: Mon, 07 May 2012 13:29:06 +0200 [thread overview]
Message-ID: <1336390146.4325.14.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4FA77FE7.5030303@broadcom.com>
On Mon, 2012-05-07 at 09:55 +0200, Arend van Spriel wrote:
> On 05/07/2012 08:34 AM, Johannes Berg wrote:
> > On Sun, 2012-05-06 at 18:30 -0500, Larry Finger wrote:
> >> Hi,
> >>
> >> I am getting the following warning from the latest wireless-testing system:
> >>
> >> ------------[ cut here ]------------
> >> WARNING: at net/mac80211/iface.c:162 ieee80211_check_queues+0x119/0x130
> >> [mac80211]()
> >
> >
> >> if (WARN_ON_ONCE(sdata->vif.hw_queue[i] >= n_queues))
> >>
> >> The warning is triggered for i, n_queues, and sdata->vif.hw_queue[i] all equal to 1.
> >
> > Is this a driver with just a single queue by any chance? I never tested
> > that and probably forgot to set those up correctly.
> >
>
> The bug report Larry mentions is with iwlwifi driver:
>
> pci, iwlwifi, NETWORK, Centrino Wireless-N 130 BGN
No, the bug report says rtl8187, the user said this happened when
plugging in the USB device.
I think this will fix it:
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -206,8 +206,10 @@ static void ieee80211_set_default_queues(struct ieee80211_sub_if_data *sdata)
for (i = 0; i < IEEE80211_NUM_ACS; i++) {
if (local->hw.flags & IEEE80211_HW_QUEUE_CONTROL)
sdata->vif.hw_queue[i] = IEEE80211_INVAL_HW_QUEUE;
- else
+ else if (local->hw.queues >= IEEE80211_NUM_ACS)
sdata->vif.hw_queue[i] = i;
+ else
+ sdata->vif.hw_queue[i] = 0;
}
sdata->vif.cab_queue = IEEE80211_INVAL_HW_QUEUE;
}
johannes
next prev parent reply other threads:[~2012-05-07 11:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-06 23:30 WARNING: at net/mac80211/iface.c:162 Larry Finger
2012-05-07 6:34 ` Johannes Berg
2012-05-07 7:55 ` Arend van Spriel
2012-05-07 11:29 ` Johannes Berg [this message]
2012-05-07 15:12 ` Larry Finger
2012-05-07 15:45 ` Johannes Berg
2012-05-07 14:30 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336390146.4325.14.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox