From: Joe Perches <joe@perches.com>
To: Kalle Valo <kvalo@adurom.com>
Cc: Ben Greear <greearb@candelatech.com>,
linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net
Subject: Re: [PATCH] ath9k: Support ethtool getstats api.
Date: Tue, 08 May 2012 10:43:59 -0700 [thread overview]
Message-ID: <1336499039.29640.29.camel@joe2Laptop> (raw)
In-Reply-To: <87zk9j85ue.fsf@purkki.adurom.net>
On Tue, 2012-05-08 at 10:55 +0300, Kalle Valo wrote:
> Ben Greear <greearb@candelatech.com> writes:
>
> > No, there is a check later that does a BUG_ON if our
> > we have screwed up the indexing of the stats.
>
> Please, no BUG_ON() calls in wifi drivers. They just make users life
> miserable. WARN_ON() with a safe bailout is enough.
$ git grep -w -E "BUG|BUG_ON" drivers/net/wireless | wc -l
209
$ git grep -w -E "BUG_ON" drivers/net/wireless | wc -l
183
$ git grep -w -E "BUG_ON" drivers/net/wireless/ath | wc -l
34
Maybe something for you to look at?
next prev parent reply other threads:[~2012-05-08 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 17:23 [PATCH] ath9k: Support ethtool getstats api greearb
2012-05-07 17:33 ` Joe Perches
2012-05-07 17:57 ` Ben Greear
2012-05-08 7:55 ` Kalle Valo
2012-05-08 15:06 ` Ben Greear
2012-05-08 17:43 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-12 16:56 greearb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336499039.29640.29.camel@joe2Laptop \
--to=joe@perches.com \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=greearb@candelatech.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox