From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/7] mac80211: add tracking of temporary offchannel sdata
Date: Thu, 10 May 2012 10:02:55 +0200 [thread overview]
Message-ID: <1336636975.4334.9.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4FAB74FD.7080004@tieto.com>
On Thu, 2012-05-10 at 09:57 +0200, Michal Kazior wrote:
> >> /* Temporary remain-on-channel for off-channel operations */
> >> + struct ieee80211_sub_if_data *tmp_sdata;
> >> struct ieee80211_channel *tmp_channel;
> >> enum nl80211_channel_type tmp_channel_type;
> >
> > Do you actually need this? I'm still tempted to not worry about any of
> > this and force drivers to implement remain-on-channel in the driver or
> > device for multi-channel, and this temporary thing is only used for
> > remain-on-channel operations now.
>
> No I don't. But if it's not done we break the whole thing (sw
> offchannel/scan) with my next patch. We might as well just remove all
> the sw offchannel/scan code.
>
> How many drivers are there that still depend on sw offchannel? Can we
> just go ahead and break them?
Unfortunately we can't, a lot of them require it for P2P.
I guess I need to look at this in more detail.
johannes
next prev parent reply other threads:[~2012-05-10 8:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 6:44 [RFC/PATCH] multi-channel preparation work Michal Kazior
2012-05-10 6:44 ` [PATCH 1/7] mac80211: add tracking of temporary offchannel sdata Michal Kazior
2012-05-10 7:26 ` Johannes Berg
2012-05-10 7:57 ` Michal Kazior
2012-05-10 8:02 ` Johannes Berg [this message]
2012-05-10 6:44 ` [PATCH 2/7] mac80211: split channel logic from hw_config Michal Kazior
2012-05-10 6:44 ` [PATCH 3/7] mac80211: refactor ieee80211_set_channel_type Michal Kazior
2012-05-10 6:44 ` [PATCH 4/7] mac80211: introduce ieee80211_oper_channel_type Michal Kazior
2012-05-10 6:44 ` [PATCH 5/7] cfg80211: extend get_channel to take wdev argument Michal Kazior
2012-05-10 7:29 ` Johannes Berg
2012-05-10 9:05 ` Michal Kazior
2012-05-10 10:57 ` Johannes Berg
2012-05-10 6:44 ` [PATCH 6/7] mac80211: remove _oper_channel_type Michal Kazior
2012-05-10 6:44 ` [PATCH 7/7] mac80211: move oper_channel to sdata Michal Kazior
2012-05-10 7:31 ` Johannes Berg
2012-05-10 8:59 ` Michal Kazior
2012-05-11 12:11 ` [RFC/PATCH] multi-channel preparation work Johannes Berg
2012-05-11 12:39 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336636975.4334.9.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).