From: Arik Nemtsov <arik@wizery.com>
To: <linux-wireless@vger.kernel.org>
Cc: Luciano Coelho <coelho@ti.com>, Arik Nemtsov <arik@wizery.com>
Subject: [PATCH 22/78] wlcore/wl18xx: add hw op for setting Tx HW checksum
Date: Thu, 10 May 2012 12:13:27 +0300 [thread overview]
Message-ID: <1336641263-5761-23-git-send-email-arik@wizery.com> (raw)
In-Reply-To: <1336641263-5761-1-git-send-email-arik@wizery.com>
Some chip families are capable of checksumming certain classes of Tx
packets in HW. Indicate this fact in the netdev features and perform the
HW checksum by protocol type for the 18xx family.
Fix the location of the skb network header when we move it so we can
rely on it when setting the checksum.
Signed-off-by: Arik Nemtsov <arik@wizery.com>
---
drivers/net/wireless/ti/wl12xx/main.c | 8 ++++++++
drivers/net/wireless/ti/wl18xx/acx.c | 26 ++++++++++++++++++++++++++
drivers/net/wireless/ti/wl18xx/acx.h | 16 ++++++++++++++++
drivers/net/wireless/ti/wl18xx/main.c | 31 +++++++++++++++++++++++++++++++
drivers/net/wireless/ti/wlcore/acx.h | 1 +
drivers/net/wireless/ti/wlcore/hw_ops.h | 11 +++++++++++
drivers/net/wireless/ti/wlcore/tx.c | 3 ++-
drivers/net/wireless/ti/wlcore/tx.h | 11 ++++++++++-
drivers/net/wireless/ti/wlcore/wlcore.h | 3 +++
9 files changed, 108 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ti/wl12xx/main.c b/drivers/net/wireless/ti/wl12xx/main.c
index d7dd3de..8141447 100644
--- a/drivers/net/wireless/ti/wl12xx/main.c
+++ b/drivers/net/wireless/ti/wl12xx/main.c
@@ -1288,6 +1288,13 @@ static void wl12xx_get_mac(struct wl1271 *wl)
wl12xx_get_fuse_mac(wl);
}
+static void wl12xx_set_tx_desc_csum(struct wl1271 *wl,
+ struct wl1271_tx_hw_descr *desc,
+ struct sk_buff *skb)
+{
+ desc->wl12xx_reserved = 0;
+}
+
static struct wlcore_ops wl12xx_ops = {
.identify_chip = wl12xx_identify_chip,
.identify_fw = wl12xx_identify_fw,
@@ -1306,6 +1313,7 @@ static struct wlcore_ops wl12xx_ops = {
.sta_get_ap_rate_mask = wl12xx_sta_get_ap_rate_mask,
.get_pg_ver = wl12xx_get_pg_ver,
.get_mac = wl12xx_get_mac,
+ .set_tx_desc_csum = wl12xx_set_tx_desc_csum,
};
static struct ieee80211_sta_ht_cap wl12xx_ht_cap = {
diff --git a/drivers/net/wireless/ti/wl18xx/acx.c b/drivers/net/wireless/ti/wl18xx/acx.c
index aed8d0d..3379db2 100644
--- a/drivers/net/wireless/ti/wl18xx/acx.c
+++ b/drivers/net/wireless/ti/wl18xx/acx.c
@@ -55,3 +55,29 @@ out:
return ret;
}
+
+int wl18xx_acx_set_checksum_state(struct wl1271 *wl)
+{
+ struct wl18xx_acx_checksum_state *acx;
+ int ret;
+
+ wl1271_debug(DEBUG_ACX, "acx checksum state");
+
+ acx = kzalloc(sizeof(*acx), GFP_KERNEL);
+ if (!acx) {
+ ret = -ENOMEM;
+ goto out;
+ }
+
+ acx->checksum_state = CHECKSUM_OFFLOAD_ENABLED;
+
+ ret = wl1271_cmd_configure(wl, ACX_CHECKSUM_CONFIG, acx, sizeof(*acx));
+ if (ret < 0) {
+ wl1271_warning("failed to set Tx checksum state: %d", ret);
+ goto out;
+ }
+
+out:
+ kfree(acx);
+ return ret;
+}
diff --git a/drivers/net/wireless/ti/wl18xx/acx.h b/drivers/net/wireless/ti/wl18xx/acx.h
index c8eebd8..544db6e 100644
--- a/drivers/net/wireless/ti/wl18xx/acx.h
+++ b/drivers/net/wireless/ti/wl18xx/acx.h
@@ -45,8 +45,24 @@ struct wl18xx_acx_host_config_bitmap {
} __packed;
+enum {
+ CHECKSUM_OFFLOAD_DISABLED = 0,
+ CHECKSUM_OFFLOAD_ENABLED = 1,
+ CHECKSUM_OFFLOAD_FAKE_RX = 2,
+ CHECKSUM_OFFLOAD_INVALID = 0xFF
+};
+
+struct wl18xx_acx_checksum_state {
+ struct acx_header header;
+
+ /* enum acx_checksum_state */
+ u8 checksum_state;
+ u8 pad[3];
+} __packed;
+
int wl18xx_acx_host_if_cfg_bitmap(struct wl1271 *wl, u32 host_cfg_bitmap,
u32 sdio_blk_size, u32 extra_mem_blks,
u32 len_field_size);
+int wl18xx_acx_set_checksum_state(struct wl1271 *wl);
#endif /* __WL12XX_ACX_H__ */
diff --git a/drivers/net/wireless/ti/wl18xx/main.c b/drivers/net/wireless/ti/wl18xx/main.c
index 1e0719c..c47f52c 100644
--- a/drivers/net/wireless/ti/wl18xx/main.c
+++ b/drivers/net/wireless/ti/wl18xx/main.c
@@ -21,6 +21,7 @@
#include <linux/module.h>
#include <linux/platform_device.h>
+#include <linux/ip.h>
#include "../wlcore/wlcore.h"
#include "../wlcore/debug.h"
@@ -501,9 +502,38 @@ static int wl18xx_hw_init(struct wl1271 *wl)
if (ret < 0)
return ret;
+ ret = wl18xx_acx_set_checksum_state(wl);
+ if (ret != 0)
+ return ret;
+
return ret;
}
+static void wl18xx_set_tx_desc_csum(struct wl1271 *wl,
+ struct wl1271_tx_hw_descr *desc,
+ struct sk_buff *skb)
+{
+ u32 ip_hdr_offset;
+ struct iphdr *ip_hdr;
+
+ if (skb->ip_summed != CHECKSUM_PARTIAL) {
+ desc->wl18xx_checksum_data = 0;
+ return;
+ }
+
+ ip_hdr_offset = skb_network_header(skb) - skb_mac_header(skb);
+ if (WARN_ON(ip_hdr_offset >= (1<<7))) {
+ desc->wl18xx_checksum_data = 0;
+ return;
+ }
+
+ desc->wl18xx_checksum_data = ip_hdr_offset << 1;
+
+ /* FW is interested only in the LSB of the protocol TCP=0 UDP=1 */
+ ip_hdr = (void *)skb_network_header(skb);
+ desc->wl18xx_checksum_data |= (ip_hdr->protocol & 0x01);
+}
+
static struct wlcore_ops wl18xx_ops = {
.identify_chip = wl18xx_identify_chip,
.boot = wl18xx_boot,
@@ -517,6 +547,7 @@ static struct wlcore_ops wl18xx_ops = {
.tx_immediate_compl = wl18xx_tx_immediate_completion,
.tx_delayed_compl = NULL,
.hw_init = wl18xx_hw_init,
+ .set_tx_desc_csum = wl18xx_set_tx_desc_csum,
};
int __devinit wl18xx_probe(struct platform_device *pdev)
diff --git a/drivers/net/wireless/ti/wlcore/acx.h b/drivers/net/wireless/ti/wlcore/acx.h
index 7a8dfba..e513b1b 100644
--- a/drivers/net/wireless/ti/wlcore/acx.h
+++ b/drivers/net/wireless/ti/wlcore/acx.h
@@ -1245,6 +1245,7 @@ enum {
ACX_CONFIG_HANGOVER = 0x0042,
ACX_FEATURE_CFG = 0x0043,
ACX_PROTECTION_CFG = 0x0044,
+ ACX_CHECKSUM_CONFIG = 0x0045,
};
diff --git a/drivers/net/wireless/ti/wlcore/hw_ops.h b/drivers/net/wireless/ti/wlcore/hw_ops.h
index 9384b4d..4573249 100644
--- a/drivers/net/wireless/ti/wlcore/hw_ops.h
+++ b/drivers/net/wireless/ti/wlcore/hw_ops.h
@@ -119,4 +119,15 @@ static inline int wlcore_identify_fw(struct wl1271 *wl)
return 0;
}
+static inline void
+wlcore_hw_set_tx_desc_csum(struct wl1271 *wl,
+ struct wl1271_tx_hw_descr *desc,
+ struct sk_buff *skb)
+{
+ if (!wl->ops->set_tx_desc_csum)
+ BUG_ON(1);
+
+ wl->ops->set_tx_desc_csum(wl, desc, skb);
+}
+
#endif
diff --git a/drivers/net/wireless/ti/wlcore/tx.c b/drivers/net/wireless/ti/wlcore/tx.c
index b4e02ef..44e4e7b 100644
--- a/drivers/net/wireless/ti/wlcore/tx.c
+++ b/drivers/net/wireless/ti/wlcore/tx.c
@@ -270,6 +270,7 @@ static void wl1271_tx_fill_hdr(struct wl1271 *wl, struct wl12xx_vif *wlvif,
if (extra) {
int hdrlen = ieee80211_hdrlen(frame_control);
memmove(frame_start, hdr, hdrlen);
+ skb_set_network_header(skb, skb_network_offset(skb) + extra);
}
/* configure packet life time */
@@ -332,9 +333,9 @@ static void wl1271_tx_fill_hdr(struct wl1271 *wl, struct wl12xx_vif *wlvif,
ieee80211_has_protected(frame_control))
tx_attr |= TX_HW_ATTR_HOST_ENCRYPT;
- desc->reserved = 0;
desc->tx_attr = cpu_to_le16(tx_attr);
+ wlcore_hw_set_tx_desc_csum(wl, desc, skb);
wlcore_hw_set_tx_desc_data_len(wl, desc, skb);
}
diff --git a/drivers/net/wireless/ti/wlcore/tx.h b/drivers/net/wireless/ti/wlcore/tx.h
index 2207274..e24c436 100644
--- a/drivers/net/wireless/ti/wlcore/tx.h
+++ b/drivers/net/wireless/ti/wlcore/tx.h
@@ -130,7 +130,16 @@ struct wl1271_tx_hw_descr {
u8 tid;
/* host link ID (HLID) */
u8 hlid;
- u8 reserved;
+
+ union {
+ u8 wl12xx_reserved;
+
+ /*
+ * bit 0 -> 0 = udp, 1 = tcp
+ * bit 1:7 -> IP header offset
+ */
+ u8 wl18xx_checksum_data;
+ } __packed;
} __packed;
enum wl1271_tx_hw_res_status {
diff --git a/drivers/net/wireless/ti/wlcore/wlcore.h b/drivers/net/wireless/ti/wlcore/wlcore.h
index 0b3f0b5..c062d30 100644
--- a/drivers/net/wireless/ti/wlcore/wlcore.h
+++ b/drivers/net/wireless/ti/wlcore/wlcore.h
@@ -61,6 +61,9 @@ struct wlcore_ops {
struct wl12xx_vif *wlvif);
s8 (*get_pg_ver)(struct wl1271 *wl);
void (*get_mac)(struct wl1271 *wl);
+ void (*set_tx_desc_csum)(struct wl1271 *wl,
+ struct wl1271_tx_hw_descr *desc,
+ struct sk_buff *skb);
};
enum wlcore_partitions {
--
1.7.9.5
next prev parent reply other threads:[~2012-05-10 9:15 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 9:13 [PATCH 00/78] 18xx chip support Arik Nemtsov
2012-05-10 9:13 ` [PATCH 01/78] wl18xx: add new module Arik Nemtsov
2012-05-10 9:13 ` [PATCH 02/78] wlcore_sdio/wl18xx: use SDIO revision number to identify wl18xx chips Arik Nemtsov
2012-05-10 9:13 ` [PATCH 03/78] wl18xx: add empty operations struct Arik Nemtsov
2012-05-10 9:13 ` [PATCH 04/78] wl18xx: add partition table Arik Nemtsov
2012-05-10 9:13 ` [PATCH 05/78] wl18xx: add register table Arik Nemtsov
2012-05-10 9:13 ` [PATCH 06/78] wl18xx: add identify chip operation Arik Nemtsov
2012-05-10 9:13 ` [PATCH 07/78] wl18xx: add some boot operations and hw-specific configurations Arik Nemtsov
2012-05-10 9:13 ` [PATCH 08/78] wl18xx: add trigger command and ack event operations Arik Nemtsov
2012-05-10 9:13 ` [PATCH 09/78] wl18xx: create per-chip-family private storage Arik Nemtsov
2012-05-10 9:13 ` [PATCH 10/78] wl18xx: set the number of Tx descriptors Arik Nemtsov
2012-05-10 9:13 ` [PATCH 11/78] wl18xx: set normal/GEM Tx spare block counts Arik Nemtsov
2012-05-10 9:13 ` [PATCH 12/78] wl18xx: implement hw op for calculating hw block count per packet Arik Nemtsov
2012-05-10 9:13 ` [PATCH 13/78] wl18xx: implement hw op for setting blocks in hw_tx_desc Arik Nemtsov
2012-05-10 9:13 ` [PATCH 14/78] wl18xx: implement hw op for setting frame length in tx_hw_desc Arik Nemtsov
2012-05-10 9:13 ` [PATCH 15/78] wl18xx: define HW-rate translation elements/tables Arik Nemtsov
2012-05-10 9:13 ` [PATCH 16/78] wl18xx: add fw_status private data Arik Nemtsov
2012-05-10 9:13 ` [PATCH 17/78] wl18xx: set Rx block-size alignment quirk Arik Nemtsov
2012-05-10 9:13 ` [PATCH 18/78] wl18xx: implement hw op for getting rx buffer data alignment Arik Nemtsov
2012-05-10 9:13 ` [PATCH 19/78] wl18xx: implement hw op for getting rx packet data length Arik Nemtsov
2012-05-10 9:13 ` [PATCH 20/78] wl18xx: implement immediate Tx completion Arik Nemtsov
2012-05-10 9:13 ` [PATCH 21/78] wl18xx: add hw_init operation Arik Nemtsov
2012-05-10 9:13 ` Arik Nemtsov [this message]
2012-05-10 9:13 ` [PATCH 23/78] wlcore/wl18xx: add hw op for Rx HW checksum Arik Nemtsov
2012-05-10 9:13 ` [PATCH 24/78] wl18xx: add runtime configuration parameters Arik Nemtsov
2012-05-10 9:13 ` [PATCH 25/78] wlcore: track current channel type per vif Arik Nemtsov
2012-05-10 9:13 ` [PATCH 26/78] wl18xx: send channel type to FW on role start Arik Nemtsov
2012-05-10 9:13 ` [PATCH 27/78] wl18xx: ipmlement ap_rate_mask hw op Arik Nemtsov
2012-05-10 9:13 ` [PATCH 28/78] wlcore: support peer MIMO rates Arik Nemtsov
2012-05-10 9:13 ` [PATCH 29/78] wlcore/wl18xx: enable MIMO/wide-chan rates in AP-mode rate config Arik Nemtsov
2012-05-10 9:13 ` [PATCH 30/78] wl18xx: set HT capabilities Arik Nemtsov
2012-05-10 9:13 ` [PATCH 31/78] wl18xx: add module param for overriding HT caps Arik Nemtsov
2012-05-10 9:13 ` [PATCH 32/78] wl18xx: add board type module argument Arik Nemtsov
2012-05-10 9:13 ` [PATCH 33/78] wl18xx: translate and write the board type to SCR_PAD2 Arik Nemtsov
2012-05-10 9:13 ` [PATCH 34/78] wl18xx: read FW pc on recovery Arik Nemtsov
2012-05-10 9:13 ` [PATCH 35/78] wl18xx: disable FW log functionality Arik Nemtsov
2012-05-10 9:13 ` [PATCH 36/78] wl18xx: read clock frequency and do top init accordingly Arik Nemtsov
2012-05-10 9:13 ` [PATCH 37/78] wlcore: rename wl12xx.h to wlcore_i.h Arik Nemtsov
2012-05-10 9:13 ` [PATCH 38/78] wlcore/wl12xx: move ref_clock and tcxo_clock elements to wl12xx Arik Nemtsov
2012-05-10 9:13 ` [PATCH 39/78] wl18xx: implement hw op to read PG version Arik Nemtsov
2012-05-10 9:13 ` [PATCH 40/78] wlcore/wl12xx: move rx_mem_pool_addr element to wl12xx Arik Nemtsov
2012-05-10 9:13 ` [PATCH 41/78] wl18xx: init Tx-released index to 0 on HW init Arik Nemtsov
2012-05-10 9:13 ` [PATCH 42/78] wl18xx: don't upload NVS to FW Arik Nemtsov
2012-05-10 9:13 ` [PATCH 43/78] wl18xx: change board type enum according to new FW Arik Nemtsov
2012-05-10 9:13 ` [PATCH 44/78] wlcore/wl12xx: add plt_init op and move the code to wl12xx Arik Nemtsov
2012-05-10 9:13 ` [PATCH 45/78] wl18xx: add plt_init operation Arik Nemtsov
2012-05-10 9:13 ` [PATCH 46/78] wl18xx: change the low_band_component_type for HDK boards Arik Nemtsov
2012-05-10 9:13 ` [PATCH 47/78] wl18xx: add number of antennas and dc2dc type as module params Arik Nemtsov
2012-05-10 9:13 ` [PATCH 48/78] wl18xx: add module parameter to disable TCP checksum Arik Nemtsov
2012-05-10 9:13 ` [PATCH 49/78] wlcore/wl12xx/18xx: split fw_status struct into two Arik Nemtsov
2012-05-10 9:13 ` [PATCH 50/78] wl18xx: derive the MAC address from the BD_ADDR in fuse ROM Arik Nemtsov
2012-05-10 9:13 ` [PATCH 51/78] wl18xx: add a module parameter to control 11a support Arik Nemtsov
2012-05-10 9:13 ` [PATCH 52/78] wlcore: add module parameter to dump SDIO reads and writes Arik Nemtsov
2012-05-10 9:13 ` [PATCH 53/78] wl18xx: copy the default configuration before checking the board_type Arik Nemtsov
2012-05-10 9:13 ` [PATCH 54/78] wl18xx: changed default board_type to HDK Arik Nemtsov
2012-05-10 9:14 ` [PATCH 55/78] wlcore: add space for private area when allocating fw_status Arik Nemtsov
2012-05-10 9:14 ` [PATCH 56/78] wl18xx: change low_band_component_type value for COM8 Arik Nemtsov
2012-05-10 9:14 ` [PATCH 57/78] wlcore: reorder identify_chip and get_hw_info Arik Nemtsov
2012-05-10 9:14 ` [PATCH 58/78] wl18xx: disable MCS_13 for wl18xx PG 1.0 Arik Nemtsov
2012-05-10 9:14 ` [PATCH 59/78] wlcore: update beacon and probe_resp templates when rates change Arik Nemtsov
2012-05-10 9:14 ` [PATCH 60/78] wlcore: use all AP basic rates as default Arik Nemtsov
2012-05-10 9:14 ` [PATCH 61/78] wlcore: abstract debugfs fw_stats to be handled by the lower drivers Arik Nemtsov
2012-05-10 9:14 ` [PATCH 62/78] wlcore: add debugfs macro to help print fw statistics arrays Arik Nemtsov
2012-05-10 9:14 ` [PATCH 63/78] wl12xx: implement fw status debugfs entries Arik Nemtsov
2012-05-10 9:14 ` [PATCH 64/78] wl18xx: " Arik Nemtsov
2012-05-10 9:14 ` [PATCH 65/78] wlcore: create private static_data area and add operation to parse it Arik Nemtsov
2012-05-10 9:14 ` [PATCH 66/78] wl18xx: print the PHY firmware version from the private static data Arik Nemtsov
2012-05-10 9:14 ` [PATCH 67/78] wlcore: print the interrupt status when recovery is triggered Arik Nemtsov
2012-05-10 9:14 ` [PATCH 68/78] wl18xx: don't use MIMO when ht_mode is set to wide Arik Nemtsov
2012-05-10 9:14 ` [PATCH 69/78] wlcore: use proper values for supported local rates Arik Nemtsov
2012-05-10 9:14 ` [PATCH 70/78] wl18xx: add module parameter to force SISO 20MHz Arik Nemtsov
2012-05-10 9:14 ` [PATCH 71/78] wl18xx: add power limit reference value to mac_and_phy settings Arik Nemtsov
2012-05-10 9:14 ` [PATCH 72/78] wl18xx: export low/high band component values as module params Arik Nemtsov
2012-05-10 9:14 ` [PATCH 73/78] wl18xx: export pwr_limit_reference_11_abg value as a module parameter Arik Nemtsov
2012-05-10 9:14 ` [PATCH 74/78] wlcore/wl12xx/wl18xx: move lower driver debugfs to a subdir Arik Nemtsov
2012-05-10 9:14 ` [PATCH 75/78] wlcore: increase aggregation buffer size by one page Arik Nemtsov
2012-05-10 9:14 ` [PATCH 76/78] wl18xx: increase tx_ba_win_size to 64 Arik Nemtsov
2012-05-10 9:14 ` [PATCH 77/78] wl18xx: use new fw stats structures Arik Nemtsov
2012-05-10 9:14 ` [PATCH 78/78] wl18xx: change default tcp_checksum to false Arik Nemtsov
2012-05-10 9:50 ` [PATCH 00/78] 18xx chip support Kalle Valo
2012-05-10 10:11 ` Arik Nemtsov
2012-05-10 10:15 ` Kalle Valo
2012-05-10 10:25 ` Arik Nemtsov
2012-05-11 5:57 ` Luciano Coelho
2012-05-11 9:03 ` Kalle Valo
2012-06-05 14:04 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336641263-5761-23-git-send-email-arik@wizery.com \
--to=arik@wizery.com \
--cc=coelho@ti.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).