Re: [PATCH 5/7] cfg80211: extend get_channel to take wdev argument

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2012-05-10 at 11:05 +0200, Michal Kazior wrote:
> Johannes Berg wrote:
> >
> >>   	struct ieee80211_channel *(*get_channel)(struct wiphy *wiphy,
> >> -					       enum nl80211_channel_type *type);
> >> +						 struct wireless_dev *wdev,
> >> +						 enum nl80211_channel_type *type);
> >
> > Hmm. This is mostly used for monitor mode, and there we would have to
> > return NULL anyway while using multiple channels at the same time. Is it
> > really worth the complexity?
> 
> Would we really have to return NULL? With my last patch that moves 
> oper_channel to sdata it can return proper channel.
> 
> But then monitor mode.. ugh.

Well, we could return something proper for everything but monitor, but
we probably don't really care much in those cases?

For monitor we should return something if there's just a single channel
in use, and NULL otherwise I guess.

johannes