From: Johannes Berg <johannes@sipsolutions.net>
To: Bing Zhao <bzhao@marvell.com>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] mwifiex: remove set_channel cfg80211 hook
Date: Fri, 11 May 2012 20:26:15 +0200 [thread overview]
Message-ID: <1336760775.8739.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <477F20668A386D41ADCC57781B1F7043083A57BA86@SC-VEXCH1.marvell.com>
On Fri, 2012-05-11 at 11:21 -0700, Bing Zhao wrote:
> Hi Johannes,
>
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > Since mwifiex only supports managed and IBSS
> > modes, it doesn't need a set_channel call. The
> > callback might be called, but it won't matter
> > as nothing can use the channel.
>
> We still need this set_channel hander for station IBSS mode.
> User may want to use "iw mlan0 set channel 11" command to configure the channel before starting an IBSS network.
That doesn't make sense though, since you should give the channel to
join the IBSS?
iw mlan0 ibss join <SSID> 2462
So maybe mwifiex_cfg80211_join_ibss() should use the channel it gets
instead.
johannes
next prev parent reply other threads:[~2012-05-11 18:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 17:24 [PATCH] mwifiex: remove set_channel cfg80211 hook Johannes Berg
2012-05-11 18:21 ` Bing Zhao
2012-05-11 18:26 ` Johannes Berg [this message]
2012-05-11 18:27 ` Johannes Berg
2012-05-11 18:57 ` Bing Zhao
2012-05-11 19:04 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336760775.8739.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=bzhao@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox