From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:54394 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966228Ab2EOS3M (ORCPT ); Tue, 15 May 2012 14:29:12 -0400 Message-ID: <1337106548.15553.8.camel@jlt3.sipsolutions.net> (sfid-20120515_202941_027677_9A1CC0B0) Subject: Re: [RFC net-next 0/2] net: Use net__ratelimit From: Johannes Berg To: David Miller Cc: joe@perches.com, netdev@vger.kernel.org, linux-decnet-user@lists.sourceforge.net, netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, linux-wireless@vger.kernel.org, dev@openvswitch.org, linux-sctp@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 15 May 2012 20:29:08 +0200 In-Reply-To: <20120515.142405.633851408201128056.davem@davemloft.net> References: <1337105028.15553.3.camel@jlt3.sipsolutions.net> <20120515.141348.892964316296815698.davem@davemloft.net> <1337106094.15553.5.camel@jlt3.sipsolutions.net> <20120515.142405.633851408201128056.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2012-05-15 at 14:24 -0400, David Miller wrote: > > But don't you have to do something in the sources to actually get > > dynamic_debug enabled? I'm concerned this will make mac80211 debugging > > inconsistent - the normal bits are just printk() still, and the > > rate-limited bits need some special enabling? That seems odd. > > You can turn them all off or on with a simple flip of a boolean switch > at run-time. Or, alternatively, you can turn them on or off in a > finer grained manner with other run-time facilities. > > There should be a transition away from explicit KERN_DEBUG. I support that, but I think it's confusing to have things mixed. Also, we seem to have printk_ratelimit(), so I'd prefer to have that used in mac80211 instead until everything there moves over to newer facilities. johannes