[PATCH] compat: backport ether_addr_equal

[PATCH] compat: backport ether_addr_equal

[Ozan Çağlayan]

This backports:

    commit a599b0f54d233d0f63d6be9a2ff0049d24751669
    Author: Joe Perches <joe@perches.com>
    Date:   Tue May 8 18:56:45 2012 +0000

        etherdevice.h: Add ether_addr_equal

        Add a boolean function to check if 2 ethernet addresses
        are the same.

        This is to avoid any confusion about compare_ether_addr
        returning an unsigned, and not being able to use the
        compare_ether_addr function for sorting ala memcmp.

        Signed-off-by: Joe Perches <joe@perches.com>
        Signed-off-by: David S. Miller <davem@davemloft.net>

[root@ozzyfedora compat]# bin/ckmake
Trying kernel                      3.3.4-5.fc17.x86_64  [OK]

Signed-off-by: Ozan Çağlayan <ozancag@gmail.com>
---
 include/linux/compat-3.5.h |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/linux/compat-3.5.h b/include/linux/compat-3.5.h
index 554d347..a83266b 100644
--- a/include/linux/compat-3.5.h
+++ b/include/linux/compat-3.5.h
@@ -3,6 +3,7 @@
 
 #include <linux/version.h>
 #include <linux/fs.h>
+#include <linux/etherdevice.h>
 
 #if (LINUX_VERSION_CODE < KERNEL_VERSION(3,5,0))
 
@@ -12,6 +13,12 @@ extern int simple_open(struct inode *inode, struct file *file);
 #define tty_lock(__tty) tty_lock()
 #define tty_unlock(__tty) tty_unlock()
 
+/* Backport ether_addr_equal */
+static inline bool ether_addr_equal(const u8 *addr1, const u8 *addr2)
+{
+    return !compare_ether_addr(addr1, addr2);
+}
+
 #endif /* (LINUX_VERSION_CODE < KERNEL_VERSION(3,5,0)) */
 
 #endif /* LINUX_3_5_COMPAT_H */
-- 
1.7.10.1

Re: [Lf_driver_backport] [PATCH] compat: backport ether_addr_equal

[Luis R. Rodriguez]

On Wed, May 16, 2012 at 2:55 AM, Ozan Çağlayan <ozancag@gmail.com> wrote:
> This backports:
>
>    commit a599b0f54d233d0f63d6be9a2ff0049d24751669
>    Author: Joe Perches <joe@perches.com>
>    Date:   Tue May 8 18:56:45 2012 +0000
>
>        etherdevice.h: Add ether_addr_equal
>
>        Add a boolean function to check if 2 ethernet addresses
>        are the same.
>
>        This is to avoid any confusion about compare_ether_addr
>        returning an unsigned, and not being able to use the
>        compare_ether_addr function for sorting ala memcmp.
>
>        Signed-off-by: Joe Perches <joe@perches.com>
>        Signed-off-by: David S. Miller <davem@davemloft.net>
>
> [root@ozzyfedora compat]# bin/ckmake
> Trying kernel                      3.3.4-5.fc17.x86_64  [OK]
>
> Signed-off-by: Ozan Çağlayan <ozancag@gmail.com>

Thanks!! BTW I see this though:

Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

And then all I see is this when I save the e-mail to a txt file, given
that the encoding is base64. This is odd given that I see you sent
this with X-Mailer: git-send-email 1.7.10.1 -- so not sure how this
ended up going out like this.

This is what I see when I save the e-mail:

VGhpcyBiYWNrcG9ydHM6CgogICAgY29tbWl0IGE1OTliMGY1NGQyMzNkMGY2M2Q2YmU5YTJmZjAw
NDlkMjQ3NTE2NjkKICAgIEF1dGhvcjogSm9lIFBlcmNoZXMgPGpvZUBwZXJjaGVzLmNvbT4KICAg
IERhdGU6ICAgVHVlIE1heSA4IDE4OjU2OjQ1IDIwMTIgKzAwMDAKCiAgICAgICAgZXRoZXJkZXZp
Y2UuaDogQWRkIGV0aGVyX2FkZHJfZXF1YWwKCiAgICAgICAgQWRkIGEgYm9vbGVhbiBmdW5jdGlv
biB0byBjaGVjayBpZiAyIGV0aGVybmV0IGFkZHJlc3NlcwogICAgICAgIGFyZSB0aGUgc2FtZS4K
CiAgICAgICAgVGhpcyBpcyB0byBhdm9pZCBhbnkgY29uZnVzaW9uIGFib3V0IGNvbXBhcmVfZXRo
ZXJfYWRkcgogICAgICAgIHJldHVybmluZyBhbiB1bnNpZ25lZCwgYW5kIG5vdCBiZWluZyBhYmxl
IHRvIHVzZSB0aGUKICAgICAgICBjb21wYXJlX2V0aGVyX2FkZHIgZnVuY3Rpb24gZm9yIHNvcnRp
bmcgYWxhIG1lbWNtcC4KCiAgICAgICAgU2lnbmVkLW9mZi1ieTogSm9lIFBlcmNoZXMgPGpvZUBw
ZXJjaGVzLmNvbT4KICAgICAgICBTaWduZWQtb2ZmLWJ5OiBEYXZpZCBTLiBNaWxsZXIgPGRhdmVt
QGRhdmVtbG9mdC5uZXQ+Cgpbcm9vdEBvenp5ZmVkb3JhIGNvbXBhdF0jIGJpbi9ja21ha2UKVHJ5
aW5nIGtlcm5lbCAgICAgICAgICAgICAgICAgICAgICAzLjMuNC01LmZjMTcueDg2XzY0ICBbT0td
CgpTaWduZWQtb2ZmLWJ5OiBPemFuIMOHYcSfbGF5YW4gPG96YW5jYWdAZ21haWwuY29tPgotLS0K
IGluY2x1ZGUvbGludXgvY29tcGF0LTMuNS5oIHwgICAgNyArKysrKysrCiAxIGZpbGUgY2hhbmdl
ZCwgNyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9jb21wYXQtMy41
LmggYi9pbmNsdWRlL2xpbnV4L2NvbXBhdC0zLjUuaAppbmRleCA1NTRkMzQ3Li5hODMyNjZiIDEw
MDY0NAotLS0gYS9pbmNsdWRlL2xpbnV4L2NvbXBhdC0zLjUuaAorKysgYi9pbmNsdWRlL2xpbnV4
L2NvbXBhdC0zLjUuaApAQCAtMyw2ICszLDcgQEAKIAogI2luY2x1ZGUgPGxpbnV4L3ZlcnNpb24u
aD4KICNpbmNsdWRlIDxsaW51eC9mcy5oPgorI2luY2x1ZGUgPGxpbnV4L2V0aGVyZGV2aWNlLmg+
CiAKICNpZiAoTElOVVhfVkVSU0lPTl9DT0RFIDwgS0VSTkVMX1ZFUlNJT04oMyw1LDApKQogCkBA
IC0xMiw2ICsxMywxMiBAQCBleHRlcm4gaW50IHNpbXBsZV9vcGVuKHN0cnVjdCBpbm9kZSAqaW5v
ZGUsIHN0cnVjdCBmaWxlICpmaWxlKTsKICNkZWZpbmUgdHR5X2xvY2soX190dHkpIHR0eV9sb2Nr
KCkKICNkZWZpbmUgdHR5X3VubG9jayhfX3R0eSkgdHR5X3VubG9jaygpCiAKKy8qIEJhY2twb3J0
IGV0aGVyX2FkZHJfZXF1YWwgKi8KK3N0YXRpYyBpbmxpbmUgYm9vbCBldGhlcl9hZGRyX2VxdWFs
KGNvbnN0IHU4ICphZGRyMSwgY29uc3QgdTggKmFkZHIyKQoreworICAgIHJldHVybiAhY29tcGFy
ZV9ldGhlcl9hZGRyKGFkZHIxLCBhZGRyMik7Cit9CisKICNlbmRpZiAvKiAoTElOVVhfVkVSU0lP
Tl9DT0RFIDwgS0VSTkVMX1ZFUlNJT04oMyw1LDApKSAqLwogCiAjZW5kaWYgLyogTElOVVhfM181
X0NPTVBBVF9IICovCi0tIAoxLjcuMTAuMQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KTGZfZHJpdmVyX2JhY2twb3J0IG1haWxpbmcgbGlzdApMZl9kcml2
ZXJfYmFja3BvcnRAbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51
eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vbGZfZHJpdmVyX2JhY2twb3J0Cg==

Re: [Lf_driver_backport] [PATCH] compat: backport ether_addr_equal

[Luis R. Rodriguez]

On Wed, May 16, 2012 at 1:17 PM, Luis R. Rodriguez <mcgrof@frijolero.org> wrote:
> This is what I see when I save the e-mail:

<-- snip -->

I've used http://www.opinionatedgeek.com/dotnet/tools/base64decode/ to
decode this to a file, I'm testing it now with ckmake on compat and
compat-wireless, thanks!

  Luis

Re: [Lf_driver_backport] [PATCH] compat: backport ether_addr_equal

[Hauke Mehrtens]

On 05/16/2012 10:17 PM, Luis R. Rodriguez wrote:
> On Wed, May 16, 2012 at 2:55 AM, Ozan Çağlayan <ozancag@gmail.com> wrote:
>> This backports:
>>
>>    commit a599b0f54d233d0f63d6be9a2ff0049d24751669
>>    Author: Joe Perches <joe@perches.com>
>>    Date:   Tue May 8 18:56:45 2012 +0000
>>
>>        etherdevice.h: Add ether_addr_equal
>>
>>        Add a boolean function to check if 2 ethernet addresses
>>        are the same.
>>
>>        This is to avoid any confusion about compare_ether_addr
>>        returning an unsigned, and not being able to use the
>>        compare_ether_addr function for sorting ala memcmp.
>>
>>        Signed-off-by: Joe Perches <joe@perches.com>
>>        Signed-off-by: David S. Miller <davem@davemloft.net>
>>
>> [root@ozzyfedora compat]# bin/ckmake
>> Trying kernel                      3.3.4-5.fc17.x86_64  [OK]
>>
>> Signed-off-by: Ozan Çağlayan <ozancag@gmail.com>
> 
> Thanks!! BTW I see this though:
> 
> Content-Type: text/plain; charset="utf-8"
> Content-Transfer-Encoding: base64
> 
> And then all I see is this when I save the e-mail to a txt file, given
> that the encoding is base64. This is odd given that I see you sent
> this with X-Mailer: git-send-email 1.7.10.1 -- so not sure how this
> ended up going out like this.

That's strange, when I save this mail I got over the mailing list with
Thunderbird it is not based64 encoded and when looking into the source
code with my mail program it is normal text mail.

From:	=?UTF-8?q?Ozan=20=C3=87a=C4=9Flayan?= <ozancag@gmail.com>
Subject: [PATCH] compat: backport ether_addr_equal
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hauke

Re: [Lf_driver_backport] [PATCH] compat: backport ether_addr_equal

[Johannes Berg]

On Wed, 2012-05-16 at 22:37 +0200, Hauke Mehrtens wrote:

> > Content-Type: text/plain; charset="utf-8"
> > Content-Transfer-Encoding: base64
> > 
> > And then all I see is this when I save the e-mail to a txt file, given
> > that the encoding is base64. This is odd given that I see you sent
> > this with X-Mailer: git-send-email 1.7.10.1 -- so not sure how this
> > ended up going out like this.
> 
> That's strange, when I save this mail I got over the mailing list with
> Thunderbird it is not based64 encoded and when looking into the source
> code with my mail program it is normal text mail.
> 
> From:	=?UTF-8?q?Ozan=20=C3=87a=C4=9Flayan?= <ozancag@gmail.com>
> Subject: [PATCH] compat: backport ether_addr_equal
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit

Well, which list? :-)

I suspect you looked at linux-wireless, and Luis looked at
lf_driver_backport (given his reply tag), so maybe the
lf_driver_backport list re-encoded the email.

johannes

Re: [Lf_driver_backport] [PATCH] compat: backport ether_addr_equal

[Luis R. Rodriguez]

On Wed, May 16, 2012 at 1:46 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Wed, 2012-05-16 at 22:37 +0200, Hauke Mehrtens wrote:
>
>> > Content-Type: text/plain; charset="utf-8"
>> > Content-Transfer-Encoding: base64
>> >
>> > And then all I see is this when I save the e-mail to a txt file, given
>> > that the encoding is base64. This is odd given that I see you sent
>> > this with X-Mailer: git-send-email 1.7.10.1 -- so not sure how this
>> > ended up going out like this.
>>
>> That's strange, when I save this mail I got over the mailing list with
>> Thunderbird it is not based64 encoded and when looking into the source
>> code with my mail program it is normal text mail.
>>
>> From: =?UTF-8?q?Ozan=20=C3=87a=C4=9Flayan?= <ozancag@gmail.com>
>> Subject: [PATCH] compat: backport ether_addr_equal
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>
> Well, which list? :-)
>
> I suspect you looked at linux-wireless, and Luis looked at
> lf_driver_backport (given his reply tag), so maybe the
> lf_driver_backport list re-encoded the email.

Great, so gmail doesn't even let me "see" the linux-wireless e-mail if
it was sent also to lf_driver_backport, I can tell given that I cannot
see the bottom of the e-mail a footer indicating this came from
linux-wireless. If lf_driver_backport re-encoded it then it seems all
patches sent to that list get busted. Bleh. I gotta address this...

froh you seem to be listed as the owner of the list, can you review this?

  Luis

Re: [Lf_driver_backport] [PATCH] compat: backport ether_addr_equal

[Hauke Mehrtens]

On 06/11/2012 08:49 PM, Luis R. Rodriguez wrote:
> On Wed, May 16, 2012 at 1:46 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
>> On Wed, 2012-05-16 at 22:37 +0200, Hauke Mehrtens wrote:
>>
>>>> Content-Type: text/plain; charset="utf-8"
>>>> Content-Transfer-Encoding: base64
>>>>
>>>> And then all I see is this when I save the e-mail to a txt file, given
>>>> that the encoding is base64. This is odd given that I see you sent
>>>> this with X-Mailer: git-send-email 1.7.10.1 -- so not sure how this
>>>> ended up going out like this.
>>>
>>> That's strange, when I save this mail I got over the mailing list with
>>> Thunderbird it is not based64 encoded and when looking into the source
>>> code with my mail program it is normal text mail.
>>>
>>> From: =?UTF-8?q?Ozan=20=C3=87a=C4=9Flayan?= <ozancag@gmail.com>
>>> Subject: [PATCH] compat: backport ether_addr_equal
>>> Content-Type: text/plain; charset=UTF-8
>>> Content-Transfer-Encoding: 8bit
>>
>> Well, which list? :-)
>>
>> I suspect you looked at linux-wireless, and Luis looked at
>> lf_driver_backport (given his reply tag), so maybe the
>> lf_driver_backport list re-encoded the email.
> 
> Great, so gmail doesn't even let me "see" the linux-wireless e-mail if
> it was sent also to lf_driver_backport, I can tell given that I cannot
> see the bottom of the e-mail a footer indicating this came from
> linux-wireless. If lf_driver_backport re-encoded it then it seems all
> patches sent to that list get busted. Bleh. I gotta address this...
> 
> froh you seem to be listed as the owner of the list, can you review this?
> 
>   Luis

All the mails I got through lf_driver_backport are base64 encoded and if
I and the lf_driver_backport mailing list are in CC or TO I just get one
mail directly and no mail through the list, different to
wireless-testing mailing list where I would get two mails, one directly
and one through the list.

Hauke

Re: [Lf_driver_backport] [PATCH] compat: backport ether_addr_equal

[Luis R. Rodriguez]

On Mon, Jun 11, 2012 at 11:51:33PM +0200, Hauke Mehrtens wrote:
> On 06/11/2012 08:49 PM, Luis R. Rodriguez wrote:
> > On Wed, May 16, 2012 at 1:46 PM, Johannes Berg
> > <johannes@sipsolutions.net> wrote:
> >> On Wed, 2012-05-16 at 22:37 +0200, Hauke Mehrtens wrote:
> >>
> >>>> Content-Type: text/plain; charset="utf-8"
> >>>> Content-Transfer-Encoding: base64
> >>>>
> >>>> And then all I see is this when I save the e-mail to a txt file, given
> >>>> that the encoding is base64. This is odd given that I see you sent
> >>>> this with X-Mailer: git-send-email 1.7.10.1 -- so not sure how this
> >>>> ended up going out like this.
> >>>
> >>> That's strange, when I save this mail I got over the mailing list with
> >>> Thunderbird it is not based64 encoded and when looking into the source
> >>> code with my mail program it is normal text mail.
> >>>
> >>> From: =?UTF-8?q?Ozan=20=C3=87a=C4=9Flayan?= <ozancag@gmail.com>
> >>> Subject: [PATCH] compat: backport ether_addr_equal
> >>> Content-Type: text/plain; charset=UTF-8
> >>> Content-Transfer-Encoding: 8bit
> >>
> >> Well, which list? :-)
> >>
> >> I suspect you looked at linux-wireless, and Luis looked at
> >> lf_driver_backport (given his reply tag), so maybe the
> >> lf_driver_backport list re-encoded the email.
> > 
> > Great, so gmail doesn't even let me "see" the linux-wireless e-mail if
> > it was sent also to lf_driver_backport, I can tell given that I cannot
> > see the bottom of the e-mail a footer indicating this came from
> > linux-wireless. If lf_driver_backport re-encoded it then it seems all
> > patches sent to that list get busted. Bleh. I gotta address this...
> > 
> > froh you seem to be listed as the owner of the list, can you review this?
> > 
> >   Luis
> 
> All the mails I got through lf_driver_backport are base64 encoded and if
> I and the lf_driver_backport mailing list are in CC or TO I just get one
> mail directly and no mail through the list, different to
> wireless-testing mailing list where I would get two mails, one directly
> and one through the list.

Thanks Hauke, in the meantime lets ignore the lf_driver_backport list then...

  Luis