From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:40747 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755922Ab2EPP4y (ORCPT ); Wed, 16 May 2012 11:56:54 -0400 Message-ID: <1337183801.18519.7.camel@jlt3.sipsolutions.net> (sfid-20120516_175712_678201_35F8FF27) Subject: Re: [PATCH 0/3] net: mac80211: Neaten debugging From: Johannes Berg To: Joe Perches Cc: David Miller , linville@tuxdriver.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 16 May 2012 17:56:41 +0200 In-Reply-To: <1337183004.4818.2.camel@joe2Laptop> References: <1337106548.15553.8.camel@jlt3.sipsolutions.net> <20120516.012319.1903390658912592000.davem@davemloft.net> <1337155171.4367.2.camel@jlt3.sipsolutions.net> <1337181771.4818.0.camel@joe2Laptop> <1337182220.18519.5.camel@jlt3.sipsolutions.net> <1337183004.4818.2.camel@joe2Laptop> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2012-05-16 at 08:43 -0700, Joe Perches wrote: > On Wed, 2012-05-16 at 17:30 +0200, Johannes Berg wrote: > > On Wed, 2012-05-16 at 08:22 -0700, Joe Perches wrote: > > > On Wed, 2012-05-16 at 09:59 +0200, Johannes Berg wrote: > > > > I wonder if it makes sense to leave these under > > > > #ifdef though? Why #ifdef something if it's going to be invisible most > > > > of the time anyway? > > > > > > I don't understand your point. > > > #ifdef removal is a good thing. > > > > Yeah, but you left a lot of them under ifdef, and I'm wondering why you > > didn't remove them, or if you should, or ... > > Those mostly use other different > #ifdef CONFIG_SOME_OTHER_CONTROL elements. > > There are I think 3 that I left because they do > not use printk/pr_level but use wiphy_ or > netdev_. Hmm, ok. I guess I need to just look at them and decide what should be what. Thanks for the preparation work though :) johannes