From: Joe Perches <joe@perches.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: print info when disabling HT
Date: Wed, 30 May 2012 07:08:51 -0700 [thread overview]
Message-ID: <1338386931.32113.22.camel@joe2Laptop> (raw)
In-Reply-To: <1338385907.4511.22.camel@jlt3.sipsolutions.net>
On Wed, 2012-05-30 at 15:51 +0200, Johannes Berg wrote:
> On Wed, 2012-05-30 at 06:48 -0700, Joe Perches wrote:
> > On Wed, 2012-05-30 at 13:56 +0200, Johannes Berg wrote:
> > > Make mac80211 print a message when it disables
> > > HT due to the connection using WEP/TKIP or due
> > > to the AP not supporting WMM/QoS.
> >
> > trivia: please use:
> > netdev_<level>(
> > not
> > netdev_printk(KERN_<LEVEL>,
> > []
> > > + netdev_printk(KERN_INFO, sdata->dev,
> > > + "disabling HT due to WEP/TKIP use\n");
> >
> > netdev_info(sdata->dev, etc...)
> >
> > etc...
>
> *sigh*
> Ok. I'm curious as to what the reason is for both, and using
> netdev_printk() everywhere?
netdev_printk isn't used generally. Other than the
netdev_<level> macros themselves, it's used only with
KERN_DEBUG to force output.
And to me, all of those netdev_level(KERN_DEBUG uses
would be better as netdev_dbg.
There are no other uses of netdev_printk except in
macros.
next prev parent reply other threads:[~2012-05-30 14:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 11:56 [PATCH] mac80211: print info when disabling HT Johannes Berg
2012-05-30 13:48 ` Joe Perches
2012-05-30 13:51 ` Johannes Berg
2012-05-30 14:08 ` Joe Perches [this message]
2012-05-30 14:18 ` Johannes Berg
2012-05-30 13:57 ` [PATCH v2] " Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2012-06-06 6:05 [PATCH] " Johannes Berg
2012-06-08 17:38 ` John W. Linville
2012-06-08 17:51 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338386931.32113.22.camel@joe2Laptop \
--to=joe@perches.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox