Re: [PATCH] mac80211: print info when disabling HT

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2012-05-30 at 07:08 -0700, Joe Perches wrote:
> On Wed, 2012-05-30 at 15:51 +0200, Johannes Berg wrote:
> > On Wed, 2012-05-30 at 06:48 -0700, Joe Perches wrote:
> > > On Wed, 2012-05-30 at 13:56 +0200, Johannes Berg wrote:
> > > > Make mac80211 print a message when it disables
> > > > HT due to the connection using WEP/TKIP or due
> > > > to the AP not supporting WMM/QoS.
> > > 
> > > trivia: please use:
> > > 	netdev_<level>(
> > > not
> > > 	netdev_printk(KERN_<LEVEL>, 
> > > []
> > > > +			netdev_printk(KERN_INFO, sdata->dev,
> > > > +				      "disabling HT due to WEP/TKIP use\n");
> > > 
> > > 			netdev_info(sdata->dev, etc...)
> > > 
> > > etc...
> > 
> > *sigh*
> > Ok. I'm curious as to what the reason is for both, and using
> > netdev_printk() everywhere?
> 
> netdev_printk isn't used generally.  Other than the
> netdev_<level> macros themselves, it's used only with
> KERN_DEBUG to force output.
> 
> And to me, all of those netdev_level(KERN_DEBUG uses
> would be better as netdev_dbg.
> 
> There are no other uses of netdev_printk except in
> macros.

Oh, I guess I was looking at an old tree since I was preparing the patch
against wireless-testing. Thanks for the explanation.

johannes