From: Johannes Berg <johannes@sipsolutions.net>
To: Eliad Peller <eliad@wizery.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Kalle Valo <kvalo@qca.qualcomm.com>,
Luciano Coelho <coelho@ti.com>
Subject: Re: [RFC] cfg80211: don't allow WoWLAN support without CONFIG_PM
Date: Wed, 30 May 2012 16:47:36 +0200 [thread overview]
Message-ID: <1338389256.4511.26.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAB3XZEdXbxnKVXkvtHASVhFj+M1u6iA636dF0oyc=SEt+=AP5g@mail.gmail.com> (sfid-20120530_164558_100237_CFF9B053)
On Wed, 2012-05-30 at 17:45 +0300, Eliad Peller wrote:
> > +#ifdef CONFIG_PM
> > ret = enable_irq_wake(wl->irq);
> > if (!ret) {
> > wl->irq_wake_enabled = true;
> > @@ -5315,6 +5316,7 @@ int __devinit wlcore_probe(struct wl1271 *wl, struct platform_device *pdev)
> > }
> > }
> > disable_irq(wl->irq);
> > +#endif
>
> i think disable_irq should be outside the ifdef.
Well, ok, I can do that if you want, but you may still want to fix this
for 3.5 since it'll otherwise cause a runtime error (registration
failure) without CONFIG_PM and I don't think this patch will go to 3.5.
johannes
next prev parent reply other threads:[~2012-05-30 14:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 13:45 [RFC] cfg80211: don't allow WoWLAN support without CONFIG_PM Johannes Berg
2012-05-30 14:45 ` Eliad Peller
2012-05-30 14:47 ` Johannes Berg [this message]
2012-05-30 17:50 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338389256.4511.26.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=coelho@ti.com \
--cc=eliad@wizery.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).