From: Marcel Holtmann <marcel@holtmann.org>
To: 이운기 <woonki84.lee@samsung.com>
Cc: linux-wireless@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, sameo@linux.intel.com,
lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org,
kgene.kim@samsung.com
Subject: Re: [PATCH] NFC: Driver for SAMSUNG S3FHRN2 NFC Chip.
Date: Tue, 05 Jun 2012 17:38:43 +0900 [thread overview]
Message-ID: <1338885523.1817.101.camel@aeonflux> (raw)
In-Reply-To: <001201cd42ef$c283d8d0$478b8a70$%lee@samsung.com>
Hi,
> This is a driver for the S3FHRN2 NFC device. the driver is just a
> proxy getting SHDLC/HCI frames from a userspace stack.
<snip>
> +
> + info->miscdev.minor = MISC_DYNAMIC_MINOR;
> + info->miscdev.name = S3FHRN2_DRIVER_NAME;
> + info->miscdev.fops = &s3fhrn2_fops;
> + info->miscdev.parent = &client->dev;
> + ret = misc_register(&info->miscdev);
> + if (ret < 0) {
> + dev_err(&client->dev, "failed to register Device\n");
> + goto err_dev_reg;
> + }
instead of creating a misc character device, I would prefer that this
gets integrated as driver for the NFC subsystem.
We do not want to have shim NFC drivers in the kernel anymore.
Regards
Marcel
next prev parent reply other threads:[~2012-06-05 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 7:49 [PATCH] NFC: Driver for SAMSUNG S3FHRN2 NFC Chip 이운기
2012-06-05 8:38 ` Marcel Holtmann [this message]
2012-06-07 0:40 ` 이운기
2012-06-05 8:59 ` Samuel Ortiz
2012-06-07 1:10 ` 이운기
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338885523.1817.101.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=aloisio.almeida@openbossa.org \
--cc=kgene.kim@samsung.com \
--cc=lauro.venancio@openbossa.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=woonki84.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox