From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] mac80211: stop Rx during HW reconfig
Date: Wed, 06 Jun 2012 08:38:25 +0200 [thread overview]
Message-ID: <1338964705.4513.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1338964357-21685-1-git-send-email-arik@wizery.com> (sfid-20120606_083243_872029_F444401F)
On Wed, 2012-06-06 at 09:32 +0300, Arik Nemtsov wrote:
> +++ b/net/mac80211/rx.c
> @@ -3023,6 +3023,9 @@ void ieee80211_rx(struct ieee80211_hw *hw, struct sk_buff *skb)
> if (WARN_ON(!sband))
> goto drop;
>
> + /* make sure we get the latest values for the next variable checks */
> + smp_rmb();
> +
I still don't think this makes a lot of sense. It's guaranteed racy, so
what does this buy us?
johannes
prev parent reply other threads:[~2012-06-06 6:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 6:32 [PATCH v2] mac80211: stop Rx during HW reconfig Arik Nemtsov
2012-06-06 6:38 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338964705.4513.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arik@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).