From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 01/14] cfg80211: respect intf combinations for 1 interface
Date: Wed, 06 Jun 2012 10:51:42 +0200 [thread overview]
Message-ID: <1338972702.4513.24.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1338203942-5667-2-git-send-email-michal.kazior@tieto.com>
On Mon, 2012-05-28 at 13:18 +0200, Michal Kazior wrote:
> Don't ignore interface combinations when only one
> interface is up. Otherwise we may call a driver to
> create (or change) interface type to something it
> didn't report in interface combinations it
> reported.
We still check wiphy.interface_modes before we even go into this
function, no? Arguably we should move the check into the function, but
I'm not sure what you're fixing here.
johannes
next prev parent reply other threads:[~2012-06-06 8:51 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 11:18 [RFC] multi-channel work Michal Kazior
2012-05-28 11:18 ` [RFC 01/14] cfg80211: respect intf combinations for 1 interface Michal Kazior
2012-06-06 8:51 ` Johannes Berg [this message]
2012-06-06 8:56 ` Michal Kazior
2012-06-06 9:02 ` Johannes Berg
2012-05-28 11:18 ` [RFC 02/14] cfg80211: check iface combinations only when intf is running Michal Kazior
2012-06-06 8:52 ` Johannes Berg
2012-05-28 11:18 ` [RFC 03/14] cfg80211: introduce cfg80211_stop_ap Michal Kazior
2012-06-06 8:54 ` Johannes Berg
2012-05-28 11:18 ` [RFC 04/14] cfg80211: .stop_ap when interface is going down Michal Kazior
2012-06-06 8:54 ` Johannes Berg
2012-05-28 11:18 ` [RFC 05/14] cfg80211: add channel tracking for AP and mesh Michal Kazior
2012-06-06 8:55 ` Johannes Berg
2012-05-28 11:18 ` [RFC 06/14] cfg80211: introduce cfg80211_get_used_channel Michal Kazior
2012-06-06 8:57 ` Johannes Berg
2012-05-28 11:18 ` [RFC 07/14] cfg80211: track monitor interfaces count Michal Kazior
2012-05-29 14:13 ` Eliad Peller
2012-06-06 9:10 ` Johannes Berg
2012-06-06 11:40 ` Michal Kazior
2012-06-06 11:53 ` Johannes Berg
2012-06-07 2:46 ` Bing Zhao
2012-05-28 11:18 ` [RFC 08/14] mac80211: refactor virtual monitor code Michal Kazior
2012-06-06 8:58 ` Johannes Berg
2012-06-06 8:59 ` Johannes Berg
2012-06-06 9:11 ` Johannes Berg
2012-05-28 11:18 ` [RFC 09/14] cfg80211: refuse to .set_monitor_channel when non-monitors are present Michal Kazior
2012-06-06 9:11 ` Johannes Berg
2012-05-28 11:18 ` [RFC 10/14] cfg80211: track monitor channel Michal Kazior
2012-06-06 9:13 ` Johannes Berg
2012-05-28 11:18 ` [RFC 11/14] cfg80211/mac80211: remove .get_channel Michal Kazior
2012-06-06 9:14 ` Johannes Berg
2012-05-28 11:19 ` [RFC 12/14] cfg80211: move devlist locking out of can_change_interface Michal Kazior
2012-05-28 11:19 ` [RFC 13/14] cfg80211: extend combination checking to consider channels Michal Kazior
2012-05-29 14:21 ` Eliad Peller
2012-06-06 9:18 ` Johannes Berg
2012-05-28 11:19 ` [RFC 14/14] cfg80211: respect iface combinations when starting operation Michal Kazior
2012-05-29 14:52 ` Eliad Peller
2012-06-06 9:20 ` Johannes Berg
2012-05-29 7:04 ` [RFC] multi-channel work Johannes Berg
2012-05-29 7:09 ` Michal Kazior
2012-06-06 9:22 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338972702.4513.24.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).