From: Johannes Berg <johannes@sipsolutions.net>
To: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
Cc: linux-wireless@vger.kernel.org, javier@cozybit.com,
linville@tuxdriver.com, devel@lists.open80211s.org
Subject: Re: [PATCH 4/4] mac80211: invoke the timer only with correct dot11MeshHWMPRootMode value
Date: Wed, 06 Jun 2012 12:26:10 +0200 [thread overview]
Message-ID: <1338978370.4513.58.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1338978039-4269-5-git-send-email-yeohchunyeow@gmail.com> (sfid-20120606_122111_793392_49BF46F0)
On Wed, 2012-06-06 at 18:20 +0800, Chun-Yeow Yeoh wrote:
> - !conf->dot11MeshHWMPRootMode) {
> - conf->dot11MeshHWMPRootMode = 1;
> + !(conf->dot11MeshHWMPRootMode > 1)) {
> + conf->dot11MeshHWMPRootMode = 4;
if you have constants, why not use them?
johannes
prev parent reply other threads:[~2012-06-06 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 10:20 [PATCH 0/4] Support proactive PREQ mechanism in Mesh Chun-Yeow Yeoh
2012-06-06 10:20 ` [PATCH 1/4] {nl,cfg,mac}80211: implement dot11MeshHWMProotInterval and dot11MeshHWMPactivePathToRootTimeout Chun-Yeow Yeoh
2012-06-06 10:23 ` Johannes Berg
2012-06-06 10:20 ` [PATCH 2/4] mac80211: implement the proactive PREQ generation Chun-Yeow Yeoh
2012-06-06 10:24 ` Johannes Berg
2012-06-06 10:25 ` Johannes Berg
2012-06-06 10:20 ` [PATCH 3/4] mac80211: implement the proactive PREP generation Chun-Yeow Yeoh
2012-06-06 10:25 ` Johannes Berg
2012-06-06 10:20 ` [PATCH 4/4] mac80211: invoke the timer only with correct dot11MeshHWMPRootMode value Chun-Yeow Yeoh
2012-06-06 10:26 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338978370.4513.58.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=javier@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).