linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <c_tpeder@qca.qualcomm.com>
Cc: kvalo@qca.qualcomm.com, ath6kl-devel@qualcomm.com,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl80211: specify RSSI threshold when scanning
Date: Wed, 13 Jun 2012 07:40:03 +0200	[thread overview]
Message-ID: <1339566003.4519.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1339533801-32016-1-git-send-email-c_tpeder@qca.qualcomm.com>

On Tue, 2012-06-12 at 13:43 -0700, Thomas Pedersen wrote:
> Support configuring an RSSI threshold in dBm (s32) when requesting
> scheduled scan, below which a BSS won't be reported by the cfg80211
> driver.

I'm confused -- were you going to do scheduled scan only? Makes sense,
but if you could maybe change the subject a bit to "specify ... in
scheduled scan"?

> + * @NL80211_ATTR_SCHED_SCAN_MATCH_RSSI: RSSI threshold (in dBm) for reporting a
> + *	BSS in scan results. 0 to turn off filtering.

No ... leave out to turn off filtering.

> + * @rssi_thold: don't report scan results below this threshold

would be good to repeat the units


> +			rssi = tb[NL80211_ATTR_SCHED_SCAN_MATCH_SSID];

rssi = ... SSID :-)

johannes



  reply	other threads:[~2012-06-13  5:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-12 20:43 [PATCH] nl80211: specify RSSI threshold when scanning Thomas Pedersen
2012-06-13  5:40 ` Johannes Berg [this message]
2012-06-13  5:53   ` Holger Schurig
2012-06-13  5:54     ` Johannes Berg
2012-06-13 20:45     ` Pedersen, Thomas
2012-06-14  6:48       ` Johannes Berg
2012-06-13 11:37   ` Luciano Coelho
2012-06-13 11:56     ` Kalle Valo
2012-06-13 20:50       ` Pedersen, Thomas
2012-06-13 21:05         ` Luciano Coelho
2012-06-14  6:29         ` Kalle Valo
2012-06-14 19:39           ` Chadd, Adrian
2012-06-14 20:21             ` Singh, Naveen
2012-06-14 20:41               ` Chadd, Adrian
2012-06-14 21:18                 ` Singh, Naveen
2012-06-14 22:16                   ` Chadd, Adrian
2012-06-15  4:40                     ` Luciano Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339566003.4519.1.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath6kl-devel@qualcomm.com \
    --cc=c_tpeder@qca.qualcomm.com \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).