From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:46729 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750982Ab2FMIIU (ORCPT ); Wed, 13 Jun 2012 04:08:20 -0400 Message-ID: <1339574896.4519.8.camel@jlt3.sipsolutions.net> (sfid-20120613_100827_682523_18C8085C) Subject: Re: [PATCH 3.5] mac80211: stop polling in disassociation From: Johannes Berg To: Eliad Peller Cc: linux-wireless , david.spinadel@intel.com Date: Wed, 13 Jun 2012 10:08:16 +0200 In-Reply-To: (sfid-20120613_100002_998594_9796B48B) References: <1339570296.4519.7.camel@jlt3.sipsolutions.net> (sfid-20120613_100002_998594_9796B48B) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2012-06-13 at 11:00 +0300, Eliad Peller wrote: > > @@ -1329,6 +1329,8 @@ static void ieee80211_set_disassoc(struct ieee80211_sub_if_data *sdata, > > u32 changed = 0; > > u8 bssid[ETH_ALEN]; > > > > + ieee80211_stop_poll(sdata); > > + > > ASSERT_MGD_MTX(ifmgd); > > it doesn't matter much, but maybe better add the call after the > function "prologue" (lockdep, WARN_ONs, ...)? I think we shouldn't do it after the warnings since those affect the control flow. OTOH, they should never happen ... johannes