linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Will Hawkins <hawkinsw@opentechinstitute.org>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: add support for userspace to handle auth frames on adhoc ifaces
Date: Thu, 14 Jun 2012 09:13:26 +0200	[thread overview]
Message-ID: <1339658006.4909.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4FD8B5D4.8060305@opentechinstitute.org>

On Wed, 2012-06-13 at 11:46 -0400, Will Hawkins wrote:
> Hello all!
> 
> This patch allows userspace applications to use nl80211 to register for
> AUTH frames received on adhoc interfaces.
> 
> Thanks,
> Will
> 
> Signed-off-by: Will Hawkins <hawkinsw@opentechinstitute.org>

Thanks for the patch. Can I get you to write a better commit log? :-)

You should remove the "Hello" and "Thanks" portions, they shouldn't go
into the kernel's commit log after all. And then, even if I already
know, please explain in the commit log why you're making this change so
the reason gets recorded in the kernel's commit log.

Thanks,
johannes



  reply	other threads:[~2012-06-14  7:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-13 15:46 [PATCH] mac80211: add support for userspace to handle auth frames on adhoc ifaces Will Hawkins
2012-06-14  7:13 ` Johannes Berg [this message]
2012-06-14 16:45   ` Will Hawkins
2012-06-14  8:00 ` Nicolas Cavallari
2012-06-14 11:24   ` Johannes Berg
2012-06-14 12:46     ` Nicolas Cavallari
2012-06-14 16:48       ` Will Hawkins
2012-06-14 16:53       ` Johannes Berg
2012-06-14 16:55         ` Will Hawkins
2012-06-14 17:08           ` Johannes Berg
2012-06-14 18:26             ` Will Hawkins
2012-06-14 18:51               ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339658006.4909.3.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=hawkinsw@opentechinstitute.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).