* mwifiex mwifiex_add_virtual_intf return value
@ 2012-06-15 21:47 Johannes Berg
2012-06-15 21:53 ` Bing Zhao
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2012-06-15 21:47 UTC (permalink / raw)
To: Bing Zhao; +Cc: linux-wireless
I was just looking at this because I'm changing it from returning a
netdev to struct wireless_dev, but I notice that you're returning the
wrong thing on errors -- you need to return an ERR_PTR(), not NULL,
otherwise cfg80211 will crash.
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: mwifiex mwifiex_add_virtual_intf return value
2012-06-15 21:47 mwifiex mwifiex_add_virtual_intf return value Johannes Berg
@ 2012-06-15 21:53 ` Bing Zhao
0 siblings, 0 replies; 2+ messages in thread
From: Bing Zhao @ 2012-06-15 21:53 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
SGkgSm9oYW5uZXMsDQoNCj4gSSB3YXMganVzdCBsb29raW5nIGF0IHRoaXMgYmVjYXVzZSBJJ20g
Y2hhbmdpbmcgaXQgZnJvbSByZXR1cm5pbmcgYQ0KPiBuZXRkZXYgdG8gc3RydWN0IHdpcmVsZXNz
X2RldiwgYnV0IEkgbm90aWNlIHRoYXQgeW91J3JlIHJldHVybmluZyB0aGUNCj4gd3JvbmcgdGhp
bmcgb24gZXJyb3JzIC0tIHlvdSBuZWVkIHRvIHJldHVybiBhbiBFUlJfUFRSKCksIG5vdCBOVUxM
LA0KPiBvdGhlcndpc2UgY2ZnODAyMTEgd2lsbCBjcmFzaC4NCg0KVGhhbmtzIGZvciBwb2ludGlu
ZyBpdCBvdXQuIEknbGwgZml4IGl0Lg0KDQpSZWdhcmRzLA0KQmluZw0KDQo=
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-15 21:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-15 21:47 mwifiex mwifiex_add_virtual_intf return value Johannes Berg
2012-06-15 21:53 ` Bing Zhao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).